This repository was archived by the owner on Jan 11, 2021. It is now read-only.
Adding of a k8s manifest #8
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
To merge this it will also require:
|
marjamis
commented
Jan 6, 2019
| service.beta.kubernetes.io/aws-load-balancer-internal: "0.0.0.0/0" | ||
| namespace: kube-system | ||
| spec: | ||
| type: LoadBalancer |
There was a problem hiding this comment.
This should be purely a ClusterIP as this will be used via an Ingress Controller.
There was a problem hiding this comment.
Also look into restricting outside access completely as this should really only need to be used internally to the cluster.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A generic k8s manifest has been added to allow the ecr_reverse_proxy to be used within a k8s cluster which will resolve #2.