-
Notifications
You must be signed in to change notification settings - Fork 519
feat: row expanded view for table data #4787
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
export const DataSelectionPanel: React.FC<{ | ||
handleDragging: (isDragging: boolean) => void; | ||
}> = ({ handleDragging }) => { | ||
return <SelectionPanel handleDragging={handleDragging} />; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
on thing we could look at is making this a "Slot". i created a library @marimo-team/react-slotz
which we use in the codebase already - you can look for some existing usage.
this would allow the plugins to do:
{some_custom_ui}and then {some_custom_ui}
can be picked up in this sidebar
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this would also clean up a lot of the jotai state that is globally shared, but likely shouldnt be
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
really cool approach, thanks for the rec!
frontend/src/components/data-table/selection-panel/data-selection.tsx
Outdated
Show resolved
Hide resolved
frontend/src/components/editor/chrome/panels/selection-panel.tsx
Outdated
Show resolved
Hide resolved
frontend/src/components/data-table/selection-panel/data-selection.tsx
Outdated
Show resolved
Hide resolved
frontend/src/components/editor/chrome/panels/selection-panel.tsx
Outdated
Show resolved
Hide resolved
a722221
to
db3f697
Compare
🚀 Development release published. You may be able to view the changes at https://marimo.app?v=0.13.7-dev6 |
📝 Summary
Popover that displays single row data vertically. By default, it will show all rows in current page. If there is selection, it will show those rows instead.
Some limitations:
Todo:
🔍 Description of Changes
📋 Checklist