feat: image_compare
#4216
Draft
feat: image_compare
#4216
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Haleshot
commented
Mar 23, 2025
Comment on lines
+108
to
+109
| {f'<div slot="{first_slot}-label" class="label">{before_label}</div>' if show_labels else ""} | ||
| {f'<div slot="{second_slot}-label" class="label">{after_label}</div>' if show_labels else ""} |
There was a problem hiding this comment.
The labels feature isn't working correctly yet (doesn't seem to show up at all).
mscolnick
reviewed
Mar 24, 2025
|
|
||
| # Create HTML content | ||
| html_content = f""" | ||
| <script defer src="https://unpkg.com/img-comparison-slider@7/dist/index.js"></script> |
There was a problem hiding this comment.
this can be a library in our package.json so that this plugin can work offline.
we can create a stateless plugin ImageComparison. you can see how we do this with JsonOutputPlugin or AccordionPlugin.
since img-comparison-slider also may not be common. we should lazy-load the library. you can look at SliderPlugin to VegaPlugin for some exampels
There was a problem hiding this comment.
Sure; will look into this. Thanks for the feedback.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Summary
Add
mo.image_comparecomponent for side-by-side image comparison with interactive slider.Fixes #1524
🔍 Description of Changes
Still WIP (to work on certain attributes of the component not working as intended).
mo.image_compareto allow side-by-side comparison of imagesexamples/image_comparison_demo.py-> needs to be moved to an appropriate folder inexamples/📋 Checklist
📜 Reviewers
@akshayka OR @mscolnick