-
Notifications
You must be signed in to change notification settings - Fork 35
📝 Summary #112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
📝 Summary #112
Conversation
This PR introduces the Basic Charts notebook to the Plotly course. It covers: * Various categories of line charts, including basic line charts, time series line charts, and others. Relates to: Plotly course marimo-team#70 --- 📋 Checklist * [x] Include package dependencies in notebook files (using `--sandbox` as per [Marimo's documentation](https://docs.marimo.io/guides/package_management/inlining_dependencies/)) * [ ] If adding a course, include a `README.md` * [x] Keep language direct and simple.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I feel that the notebook has too many nested tabs and UI elements for a "basic charts" topic. It's not that having a dashboard-style interface is bad, but for teaching fundamentals it feels like overkill. The current approach jumps straight into complex examples without explaining what each chart type is for or when to use line vs bar vs scatter vs pie charts (refer to #99).
Also feel there's a lot of coverage on line charts specifically (pie and bar don't seem to have been mentioned).
I'd suggest restructuring this to first explain each chart type individually - what it's for, when to use it, basic examples, and how styling changes affect meaning. Walk through line charts, then bar charts, scatter plots & pie charts one by one with clear explanations.
Then maybe you could bring them together in a simpler combined interface than what's currently there.
The current approach feels more like showcasing complex UI capabilities rather than teaching chart fundamentals. Focus on the educational aspect first, then add interactivity.
Also update the PR title from "Summary" to something descriptive like "Add Basic Charts Tutorial for Plotly Course."
|
||
@app.cell(hide_code=True) | ||
def _(): | ||
import marimo as mo | ||
import numpy as np | ||
import pandas as pd | ||
import plotly.express as px | ||
import plotly.graph_objects as go | ||
import pyarrow | ||
return go, mo, np, pd, px |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would definitely suggest looking at other notebooks in the repo to understand the general template/structure that is followed (to maintain uniformity). Check out the 05_reactive_plots
and 13_window_functions
notebooks for reference - they have a clear narrative structure with proper explanations.
Also look at relevant PR #99 (statistical charts) to see how to properly explain what each chart type is for and when to use it (Plotly notebook).
This section (top of the notebook usually has):
# Basic Charts with Plotly
*By [<Your Name>](https://github.com/yourusername)*
Learn how to create and customize fundamental chart types...
Also, move the imports here to the bottom of the notebook. Shift import marimo as mo in a separate cell above the other imports so UI elements render faster.
Thanks for the clarification. I'll restructure this notebook after the conclusion of my mid-term exam on 11 July. |
This PR introduces the Basic Charts notebook to the Plotly course.
It covers:
Relates to: Plotly course #70
📋 Checklist
--sandbox
as per Marimo's documentation)README.md
📝 Summary
📋 Checklist
--sandbox
README.md