-
Notifications
You must be signed in to change notification settings - Fork 36
Add Loading Data Notebook #105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Let me know when I can review this PR. |
Hi @etrotta! Just wanted to drop-by this PR again; I remember you posting on discord about there being some blockers on explaining/showing cloud storage? Anything I can help with getting this PR merged soon/completing the notebook, etc.? |
I almost forgot about this to be honest... remembered earlier this week, but was completely out of my mind for a while before that I added an example of how to use it on a disabled cell some time ago, and personally I feel like that is good enough but don't know if you rather have something different. I'm thinking about adding a simple example using an I/O plugin within the next few days, but don't plan to make many changes to the rest before reviews. |
Looking at the notebook - it's really solid! I feel the disabled cell approach for cloud storage makes perfect sense since you can't run auth examples anyway, but showing the pattern would be appropriate (from a learning POV). The reference table is also a nice touch. |
Th recent plugin commit adds good depth. Also, what did you mean by
From my end, given the notebook topic at hand and how we are going about displaying auth-stuff and other sections, it seems great! Some small nits would be to include a summary at the end going over the contents of the notebook (learnt, etc.). Ah sorry, seems you're still adding commits. |
It is ready for reviews - that last commit was just fixing some things I missed before that I noticed taking a final look at it today I'm considering whenever or not to mention DuckDB some more considering duckdb/duckdb#17947 but not sure if it's better to mention it here, in the DuckDB course, or in both... Also given it was added this week it is not exactly well documented yet |
Included a summary at the end as suggested, might want to wait until DuckDB 1.3.2 or 1.4.0 is released for the duckdb -> polars lazyframe support added in the PR I mentioned above though (added as a disabled cell for now) |
Yup this works.
Waiting for it to get added would make sense then? I think for now, it would be fine just to have it for this course (& depending on need, it can be added to the duckdb course?) |
tbh it does feels a bit silly to wait for it, but I do think it's worth it to include in this notebook. From their Release Calendar, 1.3.2 the (tentative) release date is scheduled for next Monday (2025-07-07). I'll just wait for it before updating this PR again, but other than this part it should not change anymore. If anyone has comments/reviews I will take a look at it though, I'm also slightly curious if anyone working in the DuckDB course has opinions around this side note: Not sure if I'll wait for the documentation, maybe just contribute to their docs myself if they still haven't documented it by the time 1.3.2 releases lol |
*meant async mode in the commit message, whoops Had to use it in a project and figured it was better to mention it somewhere in the course Might want to wait until DuckDB 1.4.0 stable releases, or just merge now and update the dependencies once it does. Should be ready to merge other than that |
Hi @etrotta; will merge this PR now and update once the stable version is released (apologies for delay in responding here). Thanks again! |
📝 Summary
Adds a Notebook covering how to read & write data, covering multiple formats and sources #40
📋 Checklist
--sandbox
README.md