Build fixes #650
Open
Build fixes #650
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mirror of upstream mariadb-corporation#644
The building of RPMs assumes the code is already built. This may have been done with CMake. Having the build depends here can fail if scons isn't installed, despite is never used. Adjust rpm.sh to use teh galera-obs.spec file.
Handle with -DCMAKE_CXX_COMPILER_LAUNCHER=ccache
Detection is just for the detection of sles. Remove other RPM distros.
Use this where the distro cannot be queried with rpm.
From /etc/SuSE-release
SUSE Linux Enterprise Server 12 (s390x)
VERSION = 12
PATCHLEVEL = 5
# This file is deprecated and will be removed in a future service pack or release.
# Please check /etc/os-release for details about this release.
On SLES12:
rpm --eval '%{dist}'
%{dist}
/etc/os-release
NAME="SLES"
VERSION="12-SP5"
VERSION_ID="12.5"
PRETTY_NAME="SUSE Linux Enterprise Server 12 SP5"
ID="sles"
ANSI_COLOR="0;32"
CPE_NAME="cpe:/o:suse:sles:12:sp5"
So we use NAME/ID/VERSION_ID to form the required distro tag.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Consolidated collection of commits merged into mariadb-4.x branch to make the compilation more portable.