speedup compilation with help of cmake 3.6 pch support #13581
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since cmake 3.16 there is cross-platform support of precompiled headers in cmake. So I add code to check version of cmake, and if it is recent enough build system switches to cmake's pch support. I tested with such command: touch qt/main.cpp && time ninja MAPS.ME Before: ~ 35 seconds on my machine (average) After: ~ 21 seconds What make this speedup possible: 1. With cmake's pch support generation of precompiled headers happens only if something changed, while current PCH script cause recompilation of headers every run of ninja. It takes ~ 4 seconds 2. Now it is possible to set precompiled headers per target, and I include map/framework.hpp for "qt"
|
Looks like https://github.com/organicmaps/organicmaps could benefit from this PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since cmake 3.16 there is cross-platform support of precompiled
headers in cmake. So I add code to check version of cmake,
and if it is recent enough build system switches to cmake's pch
support.
I tested with such command:
touch qt/main.cpp && time ninja MAPS.ME
Before: ~ 35 seconds on my machine (average)
After: ~ 21 seconds (average)
What make this speedup possible:
happens only if something changed, while current PCH script cause
recompilation of headers every run of ninja. It takes ~ 4 seconds
and I include map/framework.hpp for "qt".