Proper locale support #1480
Open
Proper locale support #1480
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
no92
force-pushed
the
locale
branch
12 times, most recently
from
7fb730c to
19051fd
Compare
Member
Author
|
While this PR is ready for review, its tests will fail until the stat ABI fix in #1459 is merged. |
no92
force-pushed
the
locale
branch
4 times, most recently
from
c44c34e to
80c2daf
Compare
Dennisbonke
reviewed
Nov 3, 2025
Member
Dennisbonke
left a comment
Dennisbonke
left a comment
There was a problem hiding this comment.
I'm no locale expert but this looks nice. One question popped up in my mind while reviewing but I think this is good.
Dennisbonke
approved these changes
Nov 3, 2025
Member
Dennisbonke
left a comment
Dennisbonke
left a comment
There was a problem hiding this comment.
Again, no expert, but LGTM
Member
Author
|
Requires managarm/frigg#106. |
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.