-
Notifications
You must be signed in to change notification settings - Fork 579
Additional fix for missing pandas.Panel #887
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
@enricodetoma you need to rebase off the latest master after pinning pandas and numpy |
|
@shashank88 I rebased off the latest master, but I'm not sure what you mean about pinning pandas and numpy. |
|
Actually I'm already using Arctic successfully with pandas 1.2.3 with this change, without Panel support |
Same here, using it with latest Pandas. I don't use panels explicitly, just using tick store. Chunk store too slow to use. |
|
Any update on this review? |
dunckerr
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Enrico - we haven’t removed Panel support because we are still supporting old versions of Pandas. Am I correct that you’re forking arctic repo and removing Panel support? We are always interested to hear about any improvements to the arctic codebase.
Thanks
Duncan
|
Hi Duncan, I'm simply skipping importing Panel if it doesn't exist: |
# Conflicts: # arctic/__init__.py # setup.py
I made an additional fix to manage the case of missing
Panelin newpandasversions.In fact I discovered that in few cases (e.g.
library.delete(symbol)),PandasPanelStorestatic methodcan_write_typewas still called.With this commit,
PandasPanelStoreis not even registered as storage class ifPanelis missing frompandas.