Fix install of /etc/profile.d/mamba.sh when --prefix is set
#4057
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flying-sheep
changed the title
--prefix is set
flying-sheep
changed the title
--prefix is set--prefix is set
|
You can do a range, then the highest one in the range is used for policy defaults. |
henryiii
reviewed
Sep 2, 2025
henryiii
reviewed
Sep 3, 2025
Co-authored-by: Henry Schreiner <[email protected]>
Co-authored-by: Henry Schreiner <[email protected]>
AntoinePrv
approved these changes
Sep 19, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4057 +/- ##
=======================================
Coverage 64.14% 64.14%
=======================================
Files 303 303
Lines 38853 38853
Branches 2875 2875
=======================================
Hits 24923 24923
Misses 13863 13863
Partials 67 67 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@henryiii is this good to go? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4055
TODO: Is updating
cmake_minimum_requiredcorrect or is there a way for people to get that policy active with lower versions?