Skip to content

maint: Make spdlog a private dependency #3945

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

maint: Make spdlog a private dependency #3945

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 4 additions & 7 deletions libmamba/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -472,8 +472,9 @@ macro(libmamba_create_target target_name linkage output_name)

target_link_libraries(
${target_name}
PUBLIC fmt::fmt-header-only spdlog::spdlog_header_only yaml-cpp::yaml-cpp
PUBLIC fmt::fmt-header-only yaml-cpp::yaml-cpp
PRIVATE
spdlog::spdlog_header_only
reproc
reproc++
simdjson::simdjson_static
Expand Down Expand Up @@ -605,16 +606,12 @@ macro(libmamba_create_target target_name linkage output_name)

target_link_libraries(
${target_name}
PUBLIC
${LIBSOLV_LIBRARIES}
${LIBSOLVEXT_LIBRARIES}
yaml-cpp::yaml-cpp
fmt::fmt
PUBLIC ${LIBSOLV_LIBRARIES} ${LIBSOLVEXT_LIBRARIES} yaml-cpp::yaml-cpp fmt::fmt
PRIVATE
# Since conda-forge spdlog is built with a bundled version of fmt we use the header
# only version to avoid chasing after the correct fmt version matching the one used
# in the bundle
spdlog::spdlog_header_only
PRIVATE
${LibArchive_LIBRARIES}
${CURL_LIBRARIES}
${OPENSSL_LIBRARIES}
Expand Down
1 change: 0 additions & 1 deletion libmamba/libmambaConfig.cmake.in
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,6 @@ set(CMAKE_MODULE_PATH "${CMAKE_CURRENT_LIST_DIR};${CMAKE_MODULE_PATH}")

include(CMakeFindDependencyMacro)
find_dependency(fmt)
find_dependency(spdlog)
find_dependency(tl-expected)
find_dependency(nlohmann_json)
find_dependency(yaml-cpp)
Expand Down
Loading