Fix 1 #5
Open
Fix 1 #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For this first PR I made the following fixes:
-Fixed line 48 from the README, the command was not working
New one: ./convertToProlog.sh test-cases/containerBetterGraphProcess.sb
-Fixed indentation and transformed the code made in Python2 into Python3 for both the iOracle one and the base one.
-Fixed the swipl command from converToProlog.
-Cleaned up the code by deleting not used libraries.
-Tried to fix the "main" version of SandScout, but, in the end, it was really messy and, instead, fixed the "improved version" and now it works.
-Added the ios-sandbox-profies to the test folder.
-Added output data from the files for further inspection. I will delete all test data for the final version.
-Tried to fix the query3 from the "rules.pl" file, but it ended up not working. The logic is sound, or maybe there is something quite minuscule that I might not be able to see. As far as I tested, the query breaks down when it tries to pull data from "write operations". They are always made up as compounds, not as lists. For instance, for the new example from the README file, and that is: "./convertToProlog.sh test-cases/containerBetterGraphProcess.sb", it finds/extracts, so called "compound data", instead of list, for instance: ""^/System/Library/Carrier Bundles//carrier[.]plist$"/i". This happens only for write operations and I am out of ideas.