RFC: keep hdf5 file open #318
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We see that the application that accesses an HDF5 file with CLAM library creates an extremely high load on metadata servers if the data is on the cluster filesystem. The reason is that the file is opened and closed for each access over the iterator. This change is just an idea of how such an access pattern can be optimised by keeping the file open and closing it when the object is deleted. NOTE: The code is not tested and should be treated only as a PoC
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We see that the application that accesses an HDF5 file with CLAM library creates an extremely high load on metadata servers if the data is on the cluster filesystem. The reason is that the file is opened and closed for each access over the iterator.
This change is just an idea of how such an access pattern can be optimised by keeping the file open and closing it when the object is deleted. NOTE: The code is not tested and should be treated only as a PoC