Skip to content

fix: step 6 various bugs #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

fix: step 6 various bugs #3

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
9c4ac55
fix: step six function name and pass correct args
luetkemj Nov 4, 2019
bf27315
fix: add blocking flag to spawnMonster
luetkemj Nov 4, 2019
abcbfcc
fix: add blocking flag
luetkemj Nov 4, 2019
90aad5f
fix: compomnents object in Entity constructor
luetkemj Nov 4, 2019
2d41330
fix: syntax
luetkemj Nov 4, 2019
469b0e2
fix: make player blocking
luetkemj Nov 5, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
49 changes: 20 additions & 29 deletions docs/tutorial/part-6.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,14 +74,12 @@ Create a new file `src/monsters.js` and add a placeholder function for generatin
import Entity from "./entity";
import Fightable from "./fightable";

function makeMonster(x, y) {
function spawnMonster(x, y) {
const fightable = new Fightable(20, 0, 0);
return new Entity(spawnAt.x, spawnAt.y, "monster", {}, fightable);
return new Entity(x, y, "monster", { blocking: true }, fightable);
}

export {
makeMonster
}
export { spawnMonster };
```

We’ll deal with abstracting the player attributes later. We can get this working now by modifying the player entity creation in place in `index.js`.
Expand All @@ -95,7 +93,7 @@ const player = new Entity(
Math.floor(width / 2),
Math.floor(height / 2),
"player",
{},
{ blocking: true },
new Fightable(30, 10, 10)
);
```
Expand All @@ -112,7 +110,7 @@ class Stage {
initializeEntities(player, rooms) {
// ...

for (let r=1; r<rooms.length; r++) {
for (let r = 1; r < rooms.length; r++) {
// ...

this.addEntity(spawnMonster(spawnAt.x, spawnAt.y));
Expand Down Expand Up @@ -193,7 +191,9 @@ class Fightable {

if (attackRoll > defensiveScore) {
const damage = target.dealDamage();
console.log(`${this.owner.name} hit ${target.owner.name} for ${damage} damage`);
console.log(
`${this.owner.name} hit ${target.owner.name} for ${damage} damage`
);
} else {
console.log(`${this.owner.name} was blocked by ${target.owner.name}`);
}
Expand Down Expand Up @@ -231,7 +231,7 @@ class Entity {
// ...

for (let attribute of Object.keys(components)) {
this[attribute] = component;
this[attribute] = components[attribute];
this[attribute].owner = this;
}
}
Expand All @@ -252,8 +252,8 @@ function spawnMonster(x, y) {
const components = {
fightable: new Fightable(20, 0, 0),
volition: new Volition()
}
return new Entity(x, y, "monster", {}, components);
};
return new Entity(x, y, "monster", { blocking: true }, components);
}
```

Expand Down Expand Up @@ -318,13 +318,13 @@ The first thing we need is a list of unit vectors for the cardinal directions, s
Create a new file `src/directions.js` and add the following.

```js
const Directions {
const Directions = {
CARDINAL: [
{ x: -1, y: 0 },
{ x: 1, y: 0},
{ x: 0, y: -1 },
{ x: 0, y: 1 }
];
]
}

export default Directions;
Expand All @@ -339,7 +339,7 @@ import Random from "rung/src/random";
const rng = new Random(Math.random);

function drunkenWalk(entity, stage) {
for (let i=0; i<4; i++) {
for (let i = 0; i < 4; i++) {
let direction = Directions.CARDINAL[rng.integer(4)];
let x = entity.x + direction.x;
let y = entity.y + direction.y;
Expand All @@ -351,9 +351,7 @@ function drunkenWalk(entity, stage) {
}
}

export {
drunkenWalk
}
export { drunkenWalk };
```

Update `volition.js` to use this behavior.
Expand Down Expand Up @@ -448,9 +446,7 @@ function createPathfinder(
};
}

export {
createPathfinder
}
export { createPathfinder };
```

Of course, you could just [import a library](https://www.npmjs.com/search?q=keywords:astar) to handle the entire process of A\* searching if that suits your needs better, but there are some advantages of having the algorithm inline in your project. For one, it makes it easier to adapt the API directly to your project’s style. It should be very straightforward to adapt the code here to flip between Dijkstra’s algorithm and greedy best-first search or collect the set of visited paths in a different way. Having the code inline also facilitates experimenting with performance optimisation if needed.
Expand Down Expand Up @@ -478,7 +474,7 @@ In `stage.js`, add this `adjacentPoints` method to build up a list of neighbours

```js
// ...
import Directions from "./directions"
import Directions from "./directions";
// ...

class Stage {
Expand All @@ -505,7 +501,6 @@ class Stage {

// ...
}

```

## The traversal cost
Expand Down Expand Up @@ -543,19 +538,15 @@ In `behavior.js`, create a new function `meleeCharge` and add the cost heuristic

function meleeCharge(entity, target, stage) {
const adjacentNodes = (x, y) => stage.adjacentPoints(x, y);
const costHeuristic = (from, to) => (
Math.abs(from.x - to.x) + Math.abs(from.y - to.y) * 1.01
);
const costHeuristic = (from, to) =>
Math.abs(from.x - to.x) + Math.abs(from.y - to.y) * 1.01;
const traversalCost = (x, y) => stage.movementCost(x, y);
const isTraversable = (x, y) => stage.canMoveTo(x, y);

// Chase the player here
}

export {
drunkenWalk,
meleeCharge
}
export { drunkenWalk, meleeCharge };
```

## Chasing the player
Expand Down