refactor: optimize ConvertTo-QueryString with better null handling #1026
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
SoufiyanAk
commented
Jul 14, 2025
SoufiyanAk
commented
- Add null input validation to prevent errors
- Improve null value handling for hashtable entries and object properties
- Optimize performance by reducing redundant Get-Member calls
- Enhance error messages with more context about supported types
- Add proper ToString() conversion for non-null values
- Add null input validation to prevent errors - Improve null value handling for hashtable entries and object properties - Optimize performance by reducing redundant Get-Member calls - Enhance error messages with more context about supported types - Add proper ToString() conversion for non-null values
|
@SoufiyanAk Since this is a core part of Maester I want to be extra careful that we don't cause any issues. I've added some Pester tests in #1042 Would you be able to add additional tests for the changes you are making? Can I know what prompted this PR? Where there specific calls to Invoke-GraphRequest that were failing? If so, can you include them here in the comments and ideally as a pester test so we can verify the changes? Also this test is doing a few different things in addition to the null check (eg. perf etc). Might be better to split them into different ones. We are usually not this pedantic, but since this cmdlet is a core part of Maester and affects every test we need to be extra careful. Tx and much appreciated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.