Skip to content

Conversation

@PierrickGT
Copy link
Member

No description provided.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@PierrickGT PierrickGT force-pushed the proto-328-wrappedm-v2-migration branch from 06f773c to 6349553 Compare August 19, 2025 21:08
@github-actions
Copy link

Changes to gas cost

Generated at commit: 0245e2b7da5e58f2218a4e4659db05d620a674c4, compared to commit: 49b88215911d52a47b0da94177fb6f647d90301a

🧾 Summary (20% most significant diffs)

Contract Method Avg (+/-) %
Proxy fallback -10,915 ✅ -43.48%
WrappedMTokenHarness claimFor
stopEarningFor(address[])
transferFrom
-17,631 ✅
+3,306 ❌
-4,391 ✅
-38.41%
+12.16%
-7.43%
WrappedMToken startEarningFor
stopEarningFor
transfer
-8,117 ✅
-5,546 ✅
-3,495 ✅
-13.63%
-9.54%
-6.19%
WrappedMTokenMigratorV1 fallback +30,645 ❌ +13.55%

Full diff report 👇
Contract Deployment Cost (+/-) Method Min (+/-) % Avg (+/-) % Median (+/-) % Max (+/-) % # Calls (+/-)
Proxy 104,329 (0) fallback 4,932 (0) 0.00% 14,189 (-10,915) -43.48% 7,451 (-5,528) -42.59% 116,981 (-24,629) -17.39% 8,399 (-4,156)
WrappedMTokenHarness 4,987,078 (-220,137) MIGRATOR_KEY_PREFIX
accruedYieldOf
approve
balanceOf
balanceWithYieldOf
claimExcess
claimFor
claimRecipientFor
currentIndex
disableEarning
earningPrincipalOf
enableEarning
excess
getAccountOf
getInternalClaimRecipientOf
internalUnwrap
internalWrap
isEarning
migrationAdmin
projectedEarningSupply
setAccountOf(address,uint256)
setClaimRecipient
setEarningPrincipalOf
setEnableMIndex
setInternalClaimRecipient
setTotalEarningPrincipal
setTotalEarningSupply
setTotalNonEarningSupply
startEarningFor(address)
startEarningFor(address[])
stopEarningFor(address)
stopEarningFor(address[])
swapFacility
totalAccruedYield
totalSupply
transfer
transferFrom
unwrap
wrap
308 (+22)
2,669 (+6)
4,691 (+6)
2,639 (-16)
2,921 (+6)
14,977 (0)
5,080 (+6)
4,871 (+6)
2,589 (0)
8,743 (-15)
2,622 (+6)
8,740 (-15)
14,858 (-43)
4,878 (-35)
2,618 (+6)
532 (-44)
8,847 (+6)
2,614 (+6)
337 (+44)
7,226 (0)
5,160 (-74)
9,351 (+6)
5,554 (+6)
5,362 (0)
22,664 (-16)
2,560 (0)
2,561 (0)
2,560 (+22)
2,536 (-16)
2,679 (0)
11,232 (+2,656)
18,002 (+3,299)
316 (+22)
7,239 (0)
4,556 (+22)
2,940 (-39)
5,986 (+34)
485 (+6)
484 (+6)
+7.69%
+0.23%
+0.13%
-0.60%
+0.21%
0.00%
+0.12%
+0.12%
0.00%
-0.17%
+0.23%
-0.17%
-0.29%
-0.71%
+0.23%
-7.64%
+0.07%
+0.23%
+15.02%
0.00%
-1.41%
+0.06%
+0.11%
0.00%
-0.07%
0.00%
0.00%
+0.87%
-0.63%
0.00%
+30.97%
+22.44%
+7.48%
0.00%
+0.49%
-1.31%
+0.57%
+1.25%
+1.26%
308 (+22)
6,847 (+9)
24,200 (+6)
2,639 (-16)
8,787 (+6)
22,561 (-1,926)
28,276 (-17,631)
6,544 (+7)
5,713 (+93)
14,442 (-12)
2,622 (+6)
34,368 (-13)
16,297 (-71)
4,878 (-35)
2,618 (+6)
28,310 (-44)
37,937 (+6)
2,614 (+6)
337 (+44)
9,720 (-54)
24,646 (-200)
22,617 (+6)
5,554 (+6)
6,327 (-127)
22,664 (-16)
21,160 (-269)
20,489 (-264)
21,472 (-140)
91,332 (+1,647)
46,427 (+2,151)
63,026 (+62)
30,483 (+3,306)
316 (+22)
10,572 (+87)
4,556 (+22)
22,780 (-819)
54,744 (-4,391)
31,170 (+362)
39,456 (+20)
+7.69%
+0.13%
+0.02%
-0.60%
+0.07%
-7.87%
-38.41%
+0.11%
+1.65%
-0.08%
+0.23%
-0.04%
-0.43%
-0.71%
+0.23%
-0.16%
+0.02%
+0.23%
+15.02%
-0.55%
-0.80%
+0.03%
+0.11%
-1.97%
-0.07%
-1.26%
-1.27%
-0.65%
+1.84%
+4.86%
+0.10%
+12.16%
+7.48%
+0.83%
+0.49%
-3.47%
-7.43%
+1.18%
+0.05%
308 (+22)
7,570 (+6)
24,591 (+6)
2,639 (-16)
13,188 (+6)
17,953 (0)
10,683 (+6)
6,541 (+7)
8,192 (0)
10,844 (-11)
2,622 (+6)
34,368 (-13)
14,858 (-43)
4,878 (-35)
2,618 (+6)
26,607 (-44)
41,615 (+6)
2,614 (+6)
337 (+44)
7,226 (0)
25,060 (-74)
12,151 (+6)
5,554 (+6)
5,362 (0)
22,664 (-16)
22,460 (0)
22,461 (0)
22,460 (+22)
95,562 (+2,590)
54,661 (+3,234)
63,715 (+17)
30,483 (+3,306)
316 (+22)
12,702 (0)
4,556 (+22)
15,559 (-39)
43,738 (-33,089)
29,736 (+6)
36,544 (+6)
+7.69%
+0.08%
+0.02%
-0.60%
+0.05%
0.00%
+0.06%
+0.11%
0.00%
-0.10%
+0.23%
-0.04%
-0.29%
-0.71%
+0.23%
-0.17%
+0.01%
+0.23%
+15.02%
0.00%
-0.29%
+0.05%
+0.11%
0.00%
-0.07%
0.00%
0.00%
+0.10%
+2.79%
+6.29%
+0.03%
+12.16%
+7.48%
0.00%
+0.49%
-0.25%
-43.07%
+0.02%
+0.02%
308 (+22)
13,063 (+6)
24,591 (+6)
2,639 (-16)
13,188 (+6)
45,309 (0)
87,585 (-47,615)
8,222 (+6)
8,192 (0)
23,740 (-11)
2,622 (+6)
59,996 (-11)
17,834 (-43)
4,878 (-35)
2,618 (+6)
57,344 (-44)
60,115 (+6)
2,614 (+6)
337 (+44)
12,702 (0)
25,060 (-74)
46,351 (+6)
5,554 (+6)
22,462 (0)
22,664 (-16)
22,460 (0)
22,461 (0)
22,460 (+22)
95,562 (+2,590)
81,941 (+3,218)
69,191 (+17)
42,965 (+3,314)
316 (+22)
12,842 (0)
4,556 (+22)
88,333 (+45,637)
82,333 (+30)
34,536 (+6)
52,957 (-17,781)
+7.69%
+0.05%
+0.02%
-0.60%
+0.05%
0.00%
-35.22%
+0.07%
0.00%
-0.05%
+0.23%
-0.02%
-0.24%
-0.71%
+0.23%
-0.08%
+0.01%
+0.23%
+15.02%
0.00%
-0.29%
+0.01%
+0.11%
0.00%
-0.07%
0.00%
0.00%
+0.10%
+2.79%
+4.09%
+0.02%
+8.36%
+7.48%
0.00%
+0.49%
+106.89%
+0.04%
+0.02%
-25.14%
1 (0)
341 (0)
102 (0)
1,322 (-22)
7 (0)
101 (0)
104 (-3)
4 (0)
2,157 (-11)
3 (0)
228 (0)
2 (0)
107 (0)
4 (0)
4 (0)
9 (0)
6 (0)
206 (0)
1 (0)
101 (0)
605 (+11)
3 (0)
1 (0)
496 (+11)
2 (0)
539 (-11)
341 (-11)
698 (+11)
105 (0)
3 (0)
103 (0)
2 (0)
1 (0)
127 (0)
108 (0)
213 (0)
102 (0)
93 (-4)
104 (0)
WrappedMToken 4,489,830 (-153,683) EARNERS_LIST_NAME
accruedYieldOf
approve
balanceOf
balanceWithYieldOf
claimExcess
claimFor
claimRecipientFor
decimals
enableEarning
implementation
isEarning
migrate(address)
startEarningFor
stopEarningFor
totalAccruedYield
transfer
transferFrom
unwrap
wrap
328 (+22)
2,669 (-17)
7,513 (+6)
661 (+6)
2,920 (+28)
67,935 (-3,933)
30,642 (-142)
8,453 (-17)
337 (+22)
59,966 (-46)
368 (-66)
2,591 (+6)
17,831 (+6)
50,028 (+2,580)
51,887 (-37)
12,679 (+22)
26,865 (-15,533)
30,274 (-2,493)
29,707 (-7)
35,723 (-29)
+7.19%
-0.63%
+0.08%
+0.92%
+0.97%
-5.47%
-0.46%
-0.20%
+6.98%
-0.08%
-15.21%
+0.23%
+0.03%
+5.44%
-0.07%
+0.17%
-36.64%
-7.61%
-0.02%
-0.08%
328 (+22)
12,887 (-22)
24,537 (+6)
2,434 (+7)
10,545 (+550)
67,935 (-3,933)
36,783 (-2,110)
8,453 (-17)
337 (+22)
62,617 (-1,605)
368 (-66)
2,591 (+6)
17,831 (+6)
51,428 (-8,117)
52,563 (-5,546)
13,054 (+22)
53,008 (-3,495)
40,546 (-1,230)
48,834 (-2,851)
39,426 (-524)
+7.19%
-0.17%
+0.02%
+0.29%
+5.50%
-5.47%
-5.43%
-0.20%
+6.98%
-2.50%
-15.21%
+0.23%
+0.03%
-13.63%
-9.54%
+0.17%
-6.19%
-2.94%
-5.52%
-1.31%
328 (+22)
13,536 (-17)
24,613 (+6)
2,661 (+6)
13,787 (+28)
67,935 (-3,933)
31,518 (-142)
8,453 (-17)
337 (+22)
59,966 (-46)
368 (-66)
2,591 (+6)
17,831 (+6)
51,105 (-8,573)
52,563 (-5,546)
13,279 (+22)
60,252 (+6)
46,413 (+8)
34,507 (-7)
35,723 (-29)
+7.19%
-0.13%
+0.02%
+0.23%
+0.20%
-5.47%
-0.45%
-0.20%
+6.98%
-0.08%
-15.21%
+0.23%
+0.03%
-14.37%
-9.54%
+0.17%
+0.01%
+0.02%
-0.02%
-0.08%
328 (+22)
13,536 (-17)
24,613 (+6)
2,661 (+6)
13,914 (+28)
67,935 (-3,933)
48,190 (-6,045)
8,453 (-17)
337 (+22)
69,112 (-3,944)
368 (-66)
2,591 (+6)
17,831 (+6)
62,305 (-8,573)
53,240 (-11,055)
13,279 (+22)
76,791 (+6)
65,661 (+8)
75,322 (-6,405)
104,123 (-29)
+7.19%
-0.13%
+0.02%
+0.23%
+0.20%
-5.47%
-11.15%
-0.20%
+6.98%
-5.40%
-15.21%
+0.23%
+0.03%
-12.10%
-17.19%
+0.17%
+0.01%
+0.01%
-7.84%
-0.03%
1 (0)
501 (-4)
225 (-2)
1,861 (-15)
125 (0)
1 (0)
3 (0)
5 (0)
1 (0)
5 (0)
2 (0)
2 (0)
1 (0)
122 (-1)
2 (0)
48 (0)
324 (-3)
225 (-2)
9 (0)
216 (0)
WrappedMTokenMigratorV1 1,474,206 (+12) fallback 11,150 (0) 0.00% 256,871 (+30,645) +13.55% 282,560 (+33,870) +13.62% 283,677 (+33,870) +13.56% 21 (0)
MockSwapFacility 441,334 (0) swapInM
swapOutM
43,397 (+6)
35,859 (+34)
+0.01%
+0.09%
79,892 (-2,575)
112,582 (-5,864)
-3.12%
-4.95%
77,974 (-14)
109,176 (-24,569)
-0.02%
-18.37%
145,967 (-10,151)
136,280 (-22,776)
-6.50%
-14.32%
307 (-12)
107 (-4)
MockM 542,368 (0) balanceOf
setBalanceOf
setCurrentIndex
setPrincipalBalanceOf
593 (0)
24,181 (0)
26,568 (0)
44,151 (+19,912)
0.00%
0.00%
0.00%
+82.15%
2,361 (+8)
43,831 (+419)
43,369 (-2)
44,206 (+790)
+0.34%
+0.97%
-0.00%
+1.82%
2,593 (0)
44,129 (-12)
43,692 (0)
44,187 (0)
0.00%
-0.03%
0.00%
0.00%
2,593 (0)
44,261 (0)
43,692 (0)
44,307 (0)
0.00%
0.00%
0.00%
0.00%
820 (-8)
425 (0)
855 (-3)
202 (0)
MockRegistrar 180,239 (0) get
set
setListContains
405 (-2,000)
44,392 (+372)
22,512 (-21,900)
-83.16%
+0.85%
-49.31%
2,382 (-23)
44,392 (+64)
44,242 (-196)
-0.96%
+0.14%
-0.44%
2,405 (0)
44,392 (0)
44,424 (-12)
0.00%
0.00%
-0.03%
2,405 (0)
44,392 (0)
44,424 (-24)
0.00%
0.00%
-0.05%
360 (+164)
52 (-24)
121 (+16)

@github-actions
Copy link

LCOV of commit 6349553 during Forge Coverage #625

Summary coverage rate:
  lines......: 99.6% (261 of 262 lines)
  functions..: 100.0% (62 of 62 functions)
  branches...: 100.0% (4 of 4 branches)

Files changed coverage rate:
                                 |Lines       |Functions  |Branches    
  Filename                       |Rate     Num|Rate    Num|Rate     Num
  =====================================================================
  src/ListOfEarnersToMigrate.sol |50.0%      4| 0.0%     2|    -      0
  src/WrappedMToken.sol          |24.5%    216| 0.0%    53|    -      0
  src/WrappedMTokenMigratorV1.sol|17.1%     41|57.1%     7|    -      0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants