-
Couldn't load subscription status.
- Fork 5
feat: use SwapFacility #123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: v2
Are you sure you want to change the base?
Conversation
LCOV of commit
|
| * @param amount_ The amount of M deposited. | ||
| */ | ||
| function _wrap(address account_, address recipient_, uint240 amount_) internal { | ||
| function _wrap(address recipient_, uint240 amount_) internal { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit picking here: worth keeping
_wrap(address account, address recipient, uint256 amount)
and _unwrap(address account, uint256 amount) the same as in MExtension
|
There does not seem to be a reason or this PR as the
Perhaps such features are needed by a handful of 3rd party extensions with their own criteria and centralization needs, but hopefully M0's first party extension can remain as decentralized as possible. Anyway, just my 2 cents as an outsider. |
Proposed changes:
SwapFacilitysupportwrapWithPermitas it will be replaced with SwapFacility.swapInMWithPermitNotes:
SwapFacilitycontract after it's deployedunwraptransfers M tomsg.sender(SwapFacility) rather than recipient to be consistent withMExtensioncontract