Skip to content

Conversation

@deluca-mike
Copy link
Contributor

No description provided.

@deluca-mike deluca-mike added the enhancement New feature or request label Feb 28, 2025
@deluca-mike deluca-mike self-assigned this Feb 28, 2025
@github-actions
Copy link

github-actions bot commented Feb 28, 2025

LCOV of commit f98db89 during Forge Coverage #602

Summary coverage rate:
  lines......: 99.2% (387 of 390 lines)
  functions..: 98.9% (86 of 87 functions)
  branches...: 100.0% (23 of 23 branches)

Files changed coverage rate:
                                 |Lines       |Functions  |Branches    
  Filename                       |Rate     Num|Rate    Num|Rate     Num
  =====================================================================
  src/EarnerManager.sol          |22.1%     95| 110%    21|    -      0
  src/WrappedMToken.sol          |22.4%    263| 0.0%    58|    -      0
  src/WrappedMTokenMigratorV1.sol|20.0%     25| 0.0%     5|    -      0

@deluca-mike deluca-mike force-pushed the feat/migrationAdmin-transfer branch from 05256df to e178b1c Compare February 28, 2025 16:14
@github-actions
Copy link

github-actions bot commented Feb 28, 2025

Changes to gas cost

Generated at commit: 1d0f65009f09ea1981ffa1cdacf080204f5e172d, compared to commit: ba90ae996ee19aeab57551b96f4752ee3891fb1a

🧾 Summary (20% most significant diffs)

Contract Method Avg (+/-) %
WrappedMToken migrate()
migrate(address)
+22,118 ❌
+2,199 ❌
+106.18%
+14.20%
EarnerManagerHarness setDetails
setEarnerDetails(address,bool,uint16)
setEarnerDetails(address[],bool[],uint16[])
setInternalEarnerDetails
-21,076 ✅
-21,731 ✅
-22,569 ✅
-21,946 ✅
-68.10%
-55.51%
-58.94%
-48.99%
WrappedMTokenHarness setHasEarnerDetails +1,623 ❌ +11.11%
EarnerManager migrate(address) +2,123 ❌ +22.19%
WrappedMTokenMigratorV1 fallback +20,896 ❌ +9.83%

Full diff report 👇
Contract Deployment Cost (+/-) Method Min (+/-) % Avg (+/-) % Median (+/-) % Max (+/-) % # Calls (+/-)
WrappedMToken 4,992,223 (+167,890) MIGRATOR_KEY_PREFIX
accruedYieldOf
balanceWithYieldOf
claimExcess
claimRecipientFor
currentIndex
decimals
earnerManager
enableEarning
excess
isEarningEnabled
migrate()
migrate(address)
migrationAdmin
registrar
startEarningFor
stopEarningFor
totalEarningSupply
totalNonEarningSupply
totalSupply
transferFrom
unwrap(address,uint256)
wrapWithPermit(address,uint256,uint256,bytes)
286 (+23)
653 (-22)
915 (+23)
71,632 (-22)
4,014 (+44)
1,870 (-22)
293 (-22)
316 (+23)
82,454 (+22)
2,943 (-22)
2,501 (+22)
42,948 (+22,118)
17,685 (+2,199)
402 (+109)
316 (-22)
46,730 (0)
51,641 (+23)
414 (+23)
392 (-22)
512 (-22)
32,526 (+66)
43,886 (-22)
121,680 (-22)
+8.75%
-3.26%
+2.58%
-0.03%
+1.11%
-1.16%
-6.98%
+7.85%
+0.03%
-0.74%
+0.89%
+106.18%
+14.20%
+37.20%
-6.51%
0.00%
+0.04%
+5.88%
-5.31%
-4.12%
+0.20%
-0.05%
-0.02%
286 (+23)
2,653 (-22)
1,568 (+23)
71,632 (-22)
4,014 (+44)
2,270 (-22)
293 (-22)
316 (+23)
82,454 (+22)
3,313 (-22)
2,501 (+22)
42,948 (+22,118)
17,685 (+2,199)
402 (+109)
316 (-22)
58,828 (-21)
57,786 (+10)
414 (+23)
437 (-22)
512 (-22)
40,940 (+66)
74,191 (-22)
121,680 (-22)
+8.75%
-0.82%
+1.49%
-0.03%
+1.11%
-0.96%
-6.98%
+7.85%
+0.03%
-0.66%
+0.89%
+106.18%
+14.20%
+37.20%
-6.51%
-0.04%
+0.02%
+5.88%
-4.79%
-4.12%
+0.16%
-0.03%
-0.02%
286 (+23)
2,736 (-22)
915 (+23)
71,632 (-22)
4,014 (+44)
1,870 (-22)
293 (-22)
316 (+23)
82,454 (+22)
2,956 (-22)
2,501 (+22)
42,948 (+22,118)
17,685 (+2,199)
402 (+109)
316 (-22)
58,960 (-22)
57,786 (+10)
414 (+23)
392 (-22)
512 (-22)
45,934 (+66)
73,911 (-22)
121,680 (-22)
+8.75%
-0.80%
+2.58%
-0.03%
+1.11%
-1.16%
-6.98%
+7.85%
+0.03%
-0.74%
+0.89%
+106.18%
+14.20%
+37.20%
-6.51%
-0.04%
+0.02%
+5.88%
-5.31%
-4.12%
+0.14%
-0.03%
-0.02%
286 (+23)
9,236 (-22)
2,998 (+23)
71,632 (-22)
4,014 (+44)
3,870 (-22)
293 (-22)
316 (+23)
82,454 (+22)
10,658 (-22)
2,501 (+22)
42,948 (+22,118)
17,685 (+2,199)
402 (+109)
316 (-22)
70,160 (-22)
63,932 (-2)
414 (+23)
2,392 (-22)
512 (-22)
47,934 (+66)
102,546 (-22)
121,680 (-22)
+8.75%
-0.24%
+0.77%
-0.03%
+1.11%
-0.57%
-6.98%
+7.85%
+0.03%
-0.21%
+0.89%
+106.18%
+14.20%
+37.20%
-6.51%
-0.03%
-0.00%
+5.88%
-0.91%
-4.12%
+0.14%
-0.02%
-0.02%
1 (0)
501 (0)
35 (0)
1 (0)
5 (0)
5 (0)
1 (0)
4 (0)
3 (0)
255 (0)
2 (0)
1 (0)
1 (0)
2 (-2)
4 (0)
124 (0)
2 (0)
45 (0)
44 (0)
17 (0)
216 (0)
8 (0)
1 (0)
EarnerManagerHarness 1,623,261 (+194,950) earnerStatusFor
earnerStatusesFor
earnersListsIgnored
getEarnerDetails(address)
getEarnerDetails(address[])
isAdmin
isInAdministratedEarnersList
isInRegistrarEarnersList
registrar
setDetails
setEarnerDetails(address,bool,uint16)
setEarnerDetails(address[],bool[],uint16[])
setInternalEarnerDetails
1,304 (+22)
2,495 (+44)
1,068 (+43)
1,374 (0)
3,109 (-45)
3,507 (-22)
2,692 (+20)
1,538 (+22)
249 (-44)
584 (-21,448)
6,178 (-21,722)
6,649 (-21,890)
22,848 (-21,938)
+1.72%
+1.80%
+4.20%
0.00%
-1.43%
-0.62%
+0.75%
+1.45%
-15.02%
-97.35%
-77.86%
-76.70%
-48.98%
6,753 (+20)
14,869 (+39)
3,318 (+43)
6,888 (-3)
14,956 (-50)
4,340 (-22)
4,500 (+20)
3,788 (+22)
249 (-44)
9,871 (-21,076)
17,416 (-21,731)
15,722 (-22,569)
22,848 (-21,946)
+0.30%
+0.26%
+1.31%
-0.04%
-0.33%
-0.50%
+0.45%
+0.58%
-15.02%
-68.10%
-55.51%
-58.94%
-48.99%
8,538 (+19)
18,784 (+35)
3,318 (+43)
4,256 (-1)
14,956 (-50)
3,507 (-22)
4,500 (+20)
3,788 (+22)
249 (-44)
9,020 (-20,390)
8,998 (-21,722)
6,706 (-22,566)
22,848 (-21,950)
+0.22%
+0.19%
+1.31%
-0.02%
-0.33%
-0.62%
+0.45%
+0.58%
-15.02%
-69.33%
-70.71%
-77.09%
-49.00%
11,232 (+19)
23,921 (+35)
5,568 (+43)
12,514 (-3)
26,804 (-54)
6,007 (-22)
6,308 (+20)
6,038 (+22)
249 (-44)
31,112 (-21,715)
37,073 (-21,749)
67,042 (-23,252)
22,848 (-21,962)
+0.17%
+0.15%
+0.78%
-0.02%
-0.20%
-0.36%
+0.32%
+0.37%
-15.02%
-41.11%
-36.97%
-25.75%
-49.01%
14 (0)
14 (0)
2 (0)
12 (0)
2 (0)
3 (0)
2 (0)
2 (0)
1 (0)
8 (0)
3 (0)
7 (0)
22 (0)
WrappedMTokenHarness 5,572,870 (+195,973) CLAIM_OVERRIDE_RECIPIENT_KEY_PREFIX
accruedYieldOf
balanceOf
balanceWithYieldOf
claimExcess
claimFor
claimRecipientFor
currentIndex
decimals
disableEarning
earningPrincipalOf
enableEarning
excess
getAccountOf
getInternalClaimRecipientOf
implementation
internalUnwrap
isEarning
isEarningEnabled
mToken
migrationAdmin
pushEnableDisableEarningIndex
registrar
setAccountOf(address,uint256)
setAccountOf(address,uint256,uint256,bool,bool)
setClaimRecipient
setHasEarnerDetails
setTotalEarningPrincipal
setTotalEarningSupply
setTotalNonEarningSupply
startEarningFor(address)
startEarningFor(address[])
stopEarningFor(address)
stopEarningFor(address[])
symbol
totalAccruedYield
totalEarningPrincipal
totalEarningSupply
totalNonEarningSupply
totalSupply
transfer
unwrap(address)
unwrap(address,uint256)
wasEarningEnabled
wrap(address)
wrap(address,uint256)
wrapWithPermit(address,uint256,uint256,bytes)
wrapWithPermit(address,uint256,uint256,uint8,bytes32,bytes32)
328 (+22)
653 (-22)
656 (+22)
914 (-22)
15,005 (+22)
5,223 (0)
887 (+44)
783 (-22)
338 (+45)
8,736 (-44)
659 (+22)
8,777 (+44)
2,950 (-22)
958 (+44)
612 (-43)
435 (+45)
674 (-42)
649 (+22)
502 (-22)
337 (+22)
424 (+131)
10,586 (+22)
316 (-22)
5,279 (0)
8,304 (+43)
9,323 (+22)
5,605 (+22)
2,538 (-45)
2,561 (+22)
2,583 (+22)
2,673 (+22)
2,756 (+22)
8,781 (0)
14,863 (-45)
1,430 (-23)
1,481 (0)
446 (+42)
414 (+22)
392 (-22)
557 (+45)
3,139 (+22)
43,991 (+41,220)
486 (-22)
394 (-23)
9,771 (0)
506 (+22)
4,780 (-22)
4,225 (-43)
+7.19%
-3.26%
+3.47%
-2.35%
+0.15%
0.00%
+5.22%
-2.73%
+15.36%
-0.50%
+3.45%
+0.50%
-0.74%
+4.81%
-6.56%
+11.54%
-5.87%
+3.51%
-4.20%
+6.98%
+44.71%
+0.21%
-6.51%
0.00%
+0.52%
+0.24%
+0.39%
-1.74%
+0.87%
+0.86%
+0.83%
+0.80%
0.00%
-0.30%
-1.58%
0.00%
+10.40%
+5.61%
-5.31%
+8.79%
+0.71%
+1487.55%
-4.33%
-5.52%
0.00%
+4.55%
-0.46%
-1.01%
328 (+22)
1,259 (-71)
841 (+24)
1,765 (-22)
24,166 (-445)
25,762 (-952)
3,434 (+44)
1,399 (-8)
338 (+45)
15,957 (-44)
659 (+22)
45,627 (+44)
4,676 (-7)
1,958 (+44)
1,112 (-43)
435 (+45)
28,613 (-42)
649 (+22)
1,168 (-22)
337 (+22)
424 (+131)
44,566 (+11)
316 (-22)
24,616 (-1)
44,302 (+28)
22,589 (+22)
16,225 (+1,623)
21,305 (-222)
21,252 (-257)
21,568 (-33)
45,191 (+63)
43,743 (+22)
58,250 (-669)
27,336 (-45)
1,430 (-23)
1,778 (-8)
1,938 (-22)
1,469 (+7)
1,315 (+9)
2,168 (+45)
22,949 (-773)
50,697 (-172)
42,948 (-2,860)
1,060 (-23)
49,717 (-2,264)
47,912 (-2,198)
50,171 (-2,263)
49,619 (-2,285)
+7.19%
-5.34%
+2.94%
-1.23%
-1.81%
-3.56%
+1.30%
-0.57%
+15.36%
-0.27%
+3.45%
+0.10%
-0.15%
+2.30%
-3.72%
+11.54%
-0.15%
+3.51%
-1.85%
+6.98%
+44.71%
+0.02%
-6.51%
-0.00%
+0.06%
+0.10%
+11.11%
-1.03%
-1.19%
-0.15%
+0.14%
+0.05%
-1.14%
-0.16%
-1.58%
-0.45%
-1.12%
+0.48%
+0.69%
+2.12%
-3.26%
-0.34%
-6.24%
-2.12%
-4.36%
-4.39%
-4.32%
-4.40%
328 (+22)
653 (-977)
656 (+22)
2,404 (-22)
17,522 (+22)
7,732 (0)
2,312 (+44)
1,300 (-22)
338 (+45)
10,932 (-44)
659 (+22)
45,627 (+44)
4,446 (-9)
958 (+44)
612 (-43)
435 (+45)
26,842 (-42)
649 (+22)
502 (-22)
337 (+22)
424 (+131)
44,736 (+22)
316 (-22)
25,179 (0)
45,304 (+43)
12,123 (+22)
22,705 (+22)
22,438 (-45)
22,461 (+22)
22,483 (+22)
13,785 (+11,134)
50,716 (+22)
53,604 (0)
27,336 (-45)
1,430 (-23)
1,998 (0)
2,446 (+42)
2,414 (+22)
392 (-22)
2,557 (+45)
15,757 (+22)
43,991 (-13,461)
43,881 (-22)
394 (-23)
44,805 (-13,242)
43,939 (-13,220)
45,708 (-13,264)
45,157 (-13,285)
+7.19%
-59.94%
+3.47%
-0.91%
+0.13%
0.00%
+1.94%
-1.66%
+15.36%
-0.40%
+3.45%
+0.10%
-0.20%
+4.81%
-6.56%
+11.54%
-0.16%
+3.51%
-4.20%
+6.98%
+44.71%
+0.05%
-6.51%
0.00%
+0.10%
+0.18%
+0.10%
-0.20%
+0.10%
+0.10%
+419.99%
+0.04%
0.00%
-0.16%
-1.58%
0.00%
+1.75%
+0.92%
-5.31%
+1.79%
+0.14%
-23.43%
-0.05%
-5.52%
-22.81%
-23.13%
-22.49%
-22.73%
328 (+22)
2,143 (-22)
2,656 (+22)
2,404 (-22)
44,926 (+35)
134,360 (0)
8,225 (+44)
2,783 (-22)
338 (+45)
28,203 (-44)
659 (+22)
82,478 (+44)
10,941 (-22)
4,958 (+44)
2,612 (-43)
435 (+45)
59,837 (-42)
649 (+22)
2,502 (-22)
337 (+22)
424 (+131)
44,736 (+22)
316 (-22)
25,179 (0)
45,304 (+43)
46,323 (+22)
22,705 (+22)
22,438 (-45)
22,461 (+22)
22,483 (+22)
92,178 (+22)
77,759 (+22)
68,793 (0)
39,809 (-45)
1,430 (-23)
3,481 (0)
2,446 (+42)
2,414 (+22)
2,392 (-22)
2,557 (+45)
88,151 (+22)
59,899 (-70)
59,776 (-22)
2,394 (-23)
79,005 (-30,342)
78,139 (-30,320)
79,908 (-30,364)
79,357 (-30,385)
+7.19%
-1.02%
+0.84%
-0.91%
+0.08%
0.00%
+0.54%
-0.78%
+15.36%
-0.16%
+3.45%
+0.05%
-0.20%
+0.90%
-1.62%
+11.54%
-0.07%
+3.51%
-0.87%
+6.98%
+44.71%
+0.05%
-6.51%
0.00%
+0.10%
+0.05%
+0.10%
-0.20%
+0.10%
+0.10%
+0.02%
+0.03%
0.00%
-0.11%
-1.58%
0.00%
+1.75%
+0.92%
-0.91%
+1.79%
+0.02%
-0.12%
-0.04%
-0.95%
-27.75%
-27.96%
-27.54%
-27.69%
1 (0)
341 (0)
1,938 (-17)
7 (0)
101 (0)
107 (0)
4 (0)
3,437 (-69)
1 (0)
3 (0)
177 (+1)
2 (0)
107 (0)
4 (0)
4 (0)
1 (0)
9 (0)
155 (+1)
3 (0)
1 (0)
1 (0)
606 (-41)
1 (0)
834 (+69)
531 (-69)
3 (0)
95 (+4)
714 (-69)
516 (-69)
927 (+69)
105 (0)
3 (0)
103 (0)
2 (0)
1 (0)
127 (0)
776 (-68)
1,097 (-131)
1,282 (+119)
108 (0)
213 (0)
101 (0)
102 (0)
3 (0)
101 (0)
103 (0)
102 (0)
102 (0)
EarnerManager 1,531,188 (+153,967) getEarnerDetails
implementation
migrate(address)
registrar
9,431 (-22)
346 (-22)
11,691 (+2,123)
249 (-22)
-0.23%
-5.98%
+22.19%
-8.12%
9,450 (-22)
346 (-22)
11,691 (+2,123)
249 (-22)
-0.23%
-5.98%
+22.19%
-8.12%
9,431 (-22)
346 (-22)
11,691 (+2,123)
249 (-22)
-0.23%
-5.98%
+22.19%
-8.12%
11,716 (-25)
346 (-22)
11,691 (+2,123)
249 (-22)
-0.21%
-5.98%
+22.19%
-8.12%
120 (0)
2 (0)
1 (0)
4 (0)
WrappedMTokenMigratorV1 1,374,885 (+20,354) fallback 8,929 (+118) +1.34% 233,476 (+20,896) +9.83% 260,170 (+22,118) +9.29% 260,170 (+22,118) +9.29% 18 (0)
MockRegistrar 180,227 (0) get
set
setListContains
405 (0)
44,020 (0)
22,512 (0)
0.00%
0.00%
0.00%
2,034 (-14)
44,329 (-1)
44,257 (+24)
-0.68%
-0.00%
+0.05%
2,405 (0)
44,392 (0)
44,436 (0)
0.00%
0.00%
0.00%
2,405 (0)
44,392 (0)
44,448 (0)
0.00%
0.00%
0.00%
124 (-5)
77 (-1)
121 (+14)
MockM 534,344 (0) currentIndex
setBalanceOf
setPrincipalBalanceOf
334 (0)
24,181 (0)
24,239 (0)
0.00%
0.00%
0.00%
782 (+5)
43,421 (-46)
43,997 (-13)
+0.64%
-0.11%
-0.03%
334 (0)
44,141 (+12)
44,187 (0)
0.00%
+0.03%
0.00%
2,334 (0)
44,261 (0)
44,307 (0)
0.00%
0.00%
0.00%
2,686 (-193)
828 (0)
202 (0)
Proxy 104,329 (0) fallback 432 (0) 0.00% 21,717 (-139) -0.64% 2,701 (+10) +0.37% 140,643 (0) 0.00% 16,131 (-129)
MockEarnerManager 194,427 (0) setEarnerDetails 22,790 (0) 0.00% 44,718 (+4) +0.01% 44,702 (0) 0.00% 44,966 (0) 0.00% 214 (+4)
EarnerManagerMigrator 107,234 (-12)

@deluca-mike deluca-mike force-pushed the feat/remove-roundingError branch from ba8ef1a to ba90ae9 Compare February 28, 2025 18:48
@deluca-mike deluca-mike force-pushed the feat/migrationAdmin-transfer branch from e178b1c to 8efbd6e Compare February 28, 2025 18:49
@deluca-mike deluca-mike force-pushed the feat/migrationAdmin-transfer branch from 8efbd6e to f98db89 Compare February 28, 2025 19:05
Base automatically changed from feat/remove-roundingError to feat/remove-getSafeTransferableM March 1, 2025 03:14
Base automatically changed from feat/remove-getSafeTransferableM to feat/more-migration-tests March 1, 2025 03:16
Base automatically changed from feat/more-migration-tests to v2 March 1, 2025 03:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants