Support AbortController #44
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there 👋 I hope all is well @lukeed!
This PR adds the possibility to provide a
signal
fromAbortController
and handles abort errors by assigning.aborted = true
to theError
instance.I noticed the test-suite is currently using the
reqres.in
external service, which currently requires a "free tier API key", and limits those requests to 100/day. I've added the free API Key in the tests, but ideally it would be best to have an http server on the side, just like you have here, that responds with the expected results instead.Usage
Please let me know if you have feedback - I've been using
httpie
on colyseus.js for years and it's been serving me very well!All the best!