Expose barcode metadata through the API. #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 31, 2019
Open
lubo
requested changes
Apr 30, 2019
| https://zxing.github.io/zxing/apidocs/com/google/zxing/Binarizer.html | ||
| """ | ||
| codes = read_codes_full(*args, **kwargs) | ||
| return [text for text, points, format in codes] |
Owner
There was a problem hiding this comment.
Since this library is supposed to be lightweight, I'd rather break backward compatibility than have multiple functions, which do practically the same thing.
| Returns: | ||
| A list of barcode values. | ||
| A list [(code, position, type), ...] containing each barcode found. |
Owner
There was a problem hiding this comment.
I'd be great if we returned namedtuples here instead of regular tuples. Working with long/nested tuples can quickly become awkward.
Contributor
Author
|
No worries. I am pretty busy myself this week so I probably won't get to this right away either. But if you're patient with me we can make this happen :)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This lets me find out the coordinates and type of the barcodes detected. It remains backwards compatible.