DM-51484: Update authors API and SQL table name conventions #188
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I originally wrote these for times-square and they've been successful. Add them to ook too.
This removes the intermediate `/id/` path component, which we won't need to support other API operations. This change will help us align with new APIs that we'll be adding to Ook.
jonathansick
added a commit
to lsst-sqre/phalanx
that referenced
this pull request
Jun 20, 2025
This convention is generally more popular and will be easier to maintain going forwards.
jonathansick
force-pushed
the
tickets/DM-51484
branch
from
132bf0a to
22853bc
Compare
The structure of authordb.yaml mixes people and collaborations, but conceptually it's better to treat them separately. We may add a collaborations API in the future.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes some small but important changes to the SQL and API design conventions that will be good for the long run:
GET /authors/id/{id}endpoint to now beGET /authors/{id}to align with the other endpoints in the API.fb5ed49d63d5).