Skip to content

Conversation

@jbkalmbach
Copy link
Member

No description provided.

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@jbkalmbach jbkalmbach force-pushed the tickets/SITCOM-1145 branch from bd80faa to 8c834c4 Compare March 31, 2025 22:18
@jbkalmbach jbkalmbach changed the title Start Notebook. WET-004: Sample Comcam Analysis for blended donuts Apr 8, 2025
@jbkalmbach jbkalmbach requested a review from suberlak April 8, 2025 23:32
@jbkalmbach jbkalmbach marked this pull request as ready for review April 14, 2025 21:54
@@ -0,0 +1,385 @@
{
Copy link
Contributor

@suberlak suberlak May 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As for WET-003, would be good to clarify that it's meant to be run in an USDF (RSP) environment.


Reply via ReviewNB

@@ -0,0 +1,385 @@
{
Copy link
Contributor

@suberlak suberlak May 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use origin='lower' in plt.imshow


Reply via ReviewNB

@@ -0,0 +1,385 @@
{
Copy link
Contributor

@suberlak suberlak May 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would help to have here more explanation - are you comparing Zk estimation for these two blends against the average of that CCD? Or average of nine CCDs? Looking at the image I'm not sure.


Reply via ReviewNB

@@ -0,0 +1,385 @@
{
Copy link
Contributor

@suberlak suberlak May 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A bit underwhelmed with the comparison. I'd honestly expect that the closer the blend, the worse the performance. Didn't we take ComCam data in fields with multiple blends per CCD? Please point to a relevant dayObs / seqNum and I can rerun these cells.


Reply via ReviewNB

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants