Tickets/sitcom 2114

[kakoon]

No description provided.

[review-notebook-app]

Check out this pull request on 

See visual diffs & provide feedback on Jupyter Notebooks.

---

Powered by ReviewNB

[b1quint]

Can you remove this cell? It does not add anything to the execution.

Reply via ReviewNB

[b1quint]

May I ask you to reformat this part of the code? Maybe add spaces between logical blocks of code. For example, instead of:

lews_selected = []
hp_max_hist = np.array([])
hp_spread_max_hist = np.array([])
min_ele_range = -1  # minimum elevation change in slew, degrees
min_azi_range = -1  # minimum azimuth change in slew, degrees
hp_threshold = OPERATIONAL_LIMIT
velocity_threshold = 0.5 # deg/s
df_state = getEfdData(
    client,
    "lsst.sal.MTM1M3.logevent_detailedState",
    begin=Time(slews[0].begin, format="isot", scale="utc"),
    end=Time(slews[-1].end, format="isot", scale="utc"),
) 

Add a space to separate the variable definition from the query that is a multi-line code. Something like this:

lews_selected = []
hp_max_hist = np.array([])
hp_spread_max_hist = np.array([])
min_ele_range = -1  # minimum elevation change in slew, degrees
min_azi_range = -1  # minimum azimuth change in slew, degrees
hp_threshold = OPERATIONAL_LIMIT
velocity_threshold = 0.5 # deg/s

df_state = getEfdData(
    client,
    "lsst.sal.MTM1M3.logevent_detailedState",
    begin=Time(slews[0].begin, format="isot", scale="utc"),
    end=Time(slews[-1].end, format="isot", scale="utc"),
) 

But apply this to the whole cell. Otherwise, it is hard to read.

Reply via ReviewNB

[kakoon]

done, pushed again!

[b1quint]

The notebook execution is failing. You can find it by clicking on the "Notebook Execution" above and then clicking on your notebook. Here is a shortcut with the traceback:

https://usdf-rsp.slac.stanford.edu/times-square/github-pr/lsst-sitcom/reports-performance-summary/061c378bccd80255cd7e1374e969bb3c2f683cf3/sst/mtm1m3/M1M3_max_forces_histogram

[b1quint]

This is working good! Thank you very much!