DM-51397 Update DB Session Handling and Typing for Py3.12 #182
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- use py3.12 generic type for AnyAsynSession - apply consistent type to uses of AsyncSession - refactor typevar and typealias
tcjennings
force-pushed
the
tickets/DM-51397/py312_types
branch
from
e459dba to
83875e2
Compare
tcjennings
changed the title
- Refactor typealiases in router wrapper module - Remove "list" from spec_alias fields - Refactor typing in test modules - Update types in router tests - remove default values for TypeAliases
tcjennings
force-pushed
the
tickets/DM-51397/py312_types
branch
from
5e7423a to
2e21c32
Compare
Base automatically changed from
tickets/DM-51364/py312
to
tickets/DM-51337/release
June 23, 2025 16:47
ctslater
approved these changes
Jun 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Where possible, use Python 3.12-style generic types. The largest area of impact is the migration away from "async_scoped_session" to "AsyncSession" in the database session dependency and the attendant migration away from a
safir-provided sessionmaker.Where reasonable, refactor inconsistent or incorrect use of TypeAliases. Where there is disagreement between pylance (VS Code) and mypy, endeavor to please both but favor mypy over pylance. In some cases, the new
tystatic type checker is used to help identify issues or as a tie-breaker (ha ha).