Skip to content

Support jQuery 3 #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Support jQuery 3 #9

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
f771642
Support jQuery 3 by removing deprecated .on('ready', fn)
Feb 2, 2018
ba048ab
Version bump
Feb 2, 2018
b37bb47
Hack to squash error after bootstrap-sass upgrade
trangmei Mar 26, 2019
b2a6f2b
Merge pull request #1 from trangmei/trang/bootstrap-hack
jeremyyap Mar 26, 2019
19bc9a4
Replace deprecated DOMNodeInserted with MutationObserver
trangmei May 30, 2019
1b8e5b3
Remove older ruby builds
trangmei Jun 6, 2019
dbb964c
Merge pull request #2 from trangmei/trang/DOMNodeInserted-deprecated
jeremyyap Jun 6, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions .travis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,6 @@
sudo: false
language: ruby
rvm:
- 2.1.10
- 2.2.6
- 2.3.3
- 2.4.0
- ruby-head
Expand Down
4 changes: 2 additions & 2 deletions app/assets/javascripts/simple_form-bootstrap.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,10 +18,10 @@
tokenfields.tokenfield();
}

$(document).on('ready', function() {
$(function() {
initializeComponents(document);
});
$(document).on('DOMNodeInserted', function(e) {
$(document).on('MutationObserver', function(e) {
initializeComponents(e.target);
});
$(document).on('nested:fieldAdded', function(e) {
Expand Down
2 changes: 1 addition & 1 deletion lib/simple_form/bootstrap/version.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
module SimpleForm; end
module SimpleForm::Bootstrap
VERSION = '1.5.0'
VERSION = '1.6.0'
end