Reselect advanced schedule on modify task #3
+44
−27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…the list of preset schedules
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When modifying an existing task with a schedule that's not one of the preset schedules, the app currently defaults to the Basic schedule. This can result in a different schedule being selected if the user doesn't notice the change. This was a noticeable issue when one wanted to just change a minor detail of the task such as the description or command but would then be required to select Advanced schedule or they would have to redo the scheduling part. With this pull request, the app will first check if the existing schedule is one of the preset schedules. If it is, that schedule will be selected by default. Otherwise, the app will default to the Advanced schedule.