Skip to content

chore: bump go version to 1.25 #3194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 26, 2025
+13 −8
Merged

chore: bump go version to 1.25 #3194

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9917344
chore: bump go version to 1.25
mfranczy Sep 11, 2025
79cacef
chore(lint): add revive exception rules for already existing packages
mfranczy Sep 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .devcontainer/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
FROM mcr.microsoft.com/devcontainers/go:1.22-bullseye
FROM mcr.microsoft.com/devcontainers/go:1.25-bookworm

ARG TARGETOS
ARG TARGETARCH

RUN curl -L -o devspace "https://github.com/loft-sh/devspace/releases/latest/download/devspace-linux-${TARGETARCH}" && install -c -m 0755 devspace /usr/local/bin
RUN curl -L -o vcluster "https://github.com/loft-sh/vcluster/releases/latest/download/vcluster-linux-${TARGETARCH}" && install -c -m 0755 vcluster /usr/local/bin
RUN curl -L -o kind "https://kind.sigs.k8s.io/dl/v0.17.0/kind-linux-${TARGETARCH}" && install -c -m 0755 kind /usr/local/bin
RUN curl -L -o kind "https://kind.sigs.k8s.io/dl/v0.29.0/kind-linux-${TARGETARCH}" && install -c -m 0755 kind /usr/local/bin
RUN curl -LO https://storage.googleapis.com/kubernetes-release/release/$(curl -s https://storage.googleapis.com/kubernetes-release/release/stable.txt)/bin/linux/${TARGETARCH}/kubectl && chmod +x ./kubectl && mv ./kubectl /usr/local/bin
RUN bash -c "curl -s https://get.helm.sh/helm-v3.11.1-linux-${TARGETARCH}.tar.gz > helm3.tar.gz" && tar -zxvf helm3.tar.gz linux-${TARGETARCH}/helm && chmod +x linux-${TARGETARCH}/helm && mv linux-${TARGETARCH}/helm /usr/local/bin && rm helm3.tar.gz && rm -R linux-${TARGETARCH}
RUN bash -c "curl -s https://get.helm.sh/helm-v3.18.6-linux-${TARGETARCH}.tar.gz > helm3.tar.gz" && tar -zxvf helm3.tar.gz linux-${TARGETARCH}/helm && chmod +x linux-${TARGETARCH}/helm && mv linux-${TARGETARCH}/helm /usr/local/bin && rm helm3.tar.gz && rm -R linux-${TARGETARCH}
2 changes: 1 addition & 1 deletion .github/workflows/lint.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
uses: actions/checkout@v5

- name: Check for prohibited vcluster import in config dir
run: |

Check warning on line 28 in .github/workflows/lint.yaml

View workflow job for this annotation

GitHub Actions / Lint GitHub Actions workflows 

[actionlint] reported by reviewdog 🐶
shellcheck reported issue in this script: SC2038:warning:6:15: Use 'find .. -print0 | xargs -0 ..' or 'find .. -exec .. +' to allow non-alphanumeric filenames [shellcheck]

Raw Output:
w:.github/workflows/lint.yaml:28:9: shellcheck reported issue in this script: SC2038:warning:6:15: Use 'find .. -print0 | xargs -0 ..' or 'find .. -exec .. +' to allow non-alphanumeric filenames [shellcheck]
#!/bin/bash
set -e

Expand Down Expand Up @@ -67,4 +67,4 @@
- name: Run golangci-lint
uses: golangci/golangci-lint-action@v8
with:
version: v2.1
version: v2.4
5 changes: 5 additions & 0 deletions .golangci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,6 +87,11 @@ linters:
text: 'SA1019: (.+)Secret is deprecated: Use AdditionalSecrets instead.'
- path: pkg/config/validation.go
text: 'SA1019: (.+)Secret is deprecated: Use AdditionalSecrets instead.'
# The following exceptions apply only to existing packages that need refactoring.
# The rule remains enabled globally.
- path: ^pkg/(cli/util|server/types|snapshot/types|syncer/types|util|plugin/types)/[^/]+\.go$
linters: [revive]
text: avoid meaningless package names
paths:
- licenses
# Paths below are added by 'golangci-lint migrate' when migrating from v1 to v2. They are the
Expand Down
2 changes: 1 addition & 1 deletion CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -210,7 +210,7 @@ Test the built CLI tool

### Pre-requisites

- [Golang v1.24](https://go.dev/doc/install)
- [Golang v1.25](https://go.dev/doc/install)
- [Goreleaser](https://goreleaser.com/install/)
- [Just](https://github.com/casey/just)
- [Kind](https://kind.sigs.k8s.io/)
Expand Down
2 changes: 1 addition & 1 deletion Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ ARG KINE_VERSION="v0.13.14"
FROM rancher/kine:${KINE_VERSION} AS kine

# Build program
FROM golang:1.24 AS builder
FROM golang:1.25 AS builder

WORKDIR /vcluster-dev
ARG TARGETOS
Expand Down
2 changes: 1 addition & 1 deletion Dockerfile.cli
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM golang:1.24 as builder
FROM golang:1.25 as builder

WORKDIR /vcluster-dev
ARG TARGETOS
Expand Down
2 changes: 1 addition & 1 deletion go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
module github.com/loft-sh/vcluster

go 1.24.0
go 1.25

require (
github.com/aws/aws-sdk-go-v2 v1.36.3
Expand Down
Loading