Allow build with CMake 4.0.0 #256
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes deprecated cmake option and uses cmake 2.8.0 TARGET_FILE update cmake supported minimum versions to 2.8.0...3.10 ref: - https://cmake.org/cmake/help/latest/policy/CMP0026.html CMake Error at .../CMakeLists.txt: (GET_TARGET_PROPERTY): The LOCATION property may not be read from target "json_...". Use the target name directly with add_custom_command, or use the generator expression $<TARGET_FILE>, as appropriate. Signed-off-by: Rudi Heitbaum <[email protected]>
|
Thank you! These patches worked great on Ravenports. |
jcdubois
added a commit
to jcdubois/buildroot
that referenced
this pull request
Sep 26, 2025
yagl would not build with a recent cmake (>= 4.0.2) The bug is reported to the yajl project with a provided patch lloyd/yajl#256 So this patch just adds the provided patch to yajl in buildroot with a small rework to adapt to the buildroot patched version Signed-off-by: Jean-Christophe Dubois <[email protected]>
jcdubois
added a commit
to jcdubois/buildroot
that referenced
this pull request
Sep 27, 2025
yagl would not build with a recent cmake (>= 4.0.2) The bug is reported to the yajl project with a provided patch lloyd/yajl#256 So this patch just adds the provided patch to yajl in buildroot with a small rework to adapt to the buildroot patched version Signed-off-by: Jean-Christophe Dubois <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes deprecated cmake option and uses cmake 2.8.0 TARGET_FILE update cmake supported minimum versions to 2.8.0...3.10
ref:
CMake Error at .../CMakeLists.txt: (GET_TARGET_PROPERTY):
The LOCATION property may not be read from target "json_...". Use the
target name directly with add_custom_command, or use the generator
expression $<TARGET_FILE>, as appropriate.
fixes #254