Remove MSVC and other compiler specific code. #213
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
You should try not to use compiler specific code in the cmake scripts, because if not implemented carefully it can hurt cross compilation using other compilers, in this case for example mingw instead of msvc. All compiler specific settings should be implemented in cmake toolchain files, everything else bloats your build scripts in a best case. In a worst case it ruins your build procedure completely.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You should try not to use compiler specific code in the cmake scripts,
because if not implemented carefully it can hurt cross compilation using
other compilers, in this case for example mingw instead of msvc. All
compiler specific settings should be implemented in cmake toolchain
files, everything else bloats your build scripts in a best case. In a
worst case it ruins your build procedure completely.