Skip to content

metrics tests #4045

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

metrics tests #4045

wants to merge 1 commit into from

Conversation

@ehhuang
Copy link
Contributor

@ehhuang ehhuang commented Nov 3, 2025

  • Add _create_metric_stub_from_protobuf method to correctly parse protobuf metrics
  • Add _extract_attributes_from_data_point helper method
  • Change metric handling to use protobuf-specific parsing instead of OpenTelemetry native parsing
  • Add missing typing import
  • Add OTEL_METRIC_EXPORT_INTERVAL environment variable for test configuration

This fixes the CI failure where metrics were not being properly extracted from
protobuf data in server mode tests.

@iamemilio @ehhuang
metrics tests
7a19488 
- Add _create_metric_stub_from_protobuf method to correctly parse protobuf metrics
- Add _extract_attributes_from_data_point helper method
- Change metric handling to use protobuf-specific parsing instead of OpenTelemetry native parsing
- Add missing typing import
- Add OTEL_METRIC_EXPORT_INTERVAL environment variable for test configuration

This fixes the CI failure where metrics were not being properly extracted from
protobuf data in server mode tests.
@meta-cla meta-cla bot added the CLA Signed This label is managed by the Meta Open Source bot. label Nov 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ashwinb ashwinb Awaiting requested review from ashwinb ashwinb will be requested when the pull request is marked ready for review ashwinb is a code owner

@yanxi0830 yanxi0830 Awaiting requested review from yanxi0830 yanxi0830 will be requested when the pull request is marked ready for review yanxi0830 is a code owner

@hardikjshah hardikjshah Awaiting requested review from hardikjshah hardikjshah will be requested when the pull request is marked ready for review hardikjshah is a code owner

@raghotham raghotham Awaiting requested review from raghotham raghotham will be requested when the pull request is marked ready for review raghotham is a code owner

@terrytangyuan terrytangyuan Awaiting requested review from terrytangyuan terrytangyuan will be requested when the pull request is marked ready for review terrytangyuan is a code owner

@leseb leseb Awaiting requested review from leseb leseb will be requested when the pull request is marked ready for review leseb is a code owner

@bbrowning bbrowning Awaiting requested review from bbrowning bbrowning will be requested when the pull request is marked ready for review bbrowning is a code owner

@reluctantfuturist reluctantfuturist Awaiting requested review from reluctantfuturist reluctantfuturist will be requested when the pull request is marked ready for review reluctantfuturist is a code owner

@mattf mattf Awaiting requested review from mattf mattf will be requested when the pull request is marked ready for review mattf is a code owner

@slekkala1 slekkala1 Awaiting requested review from slekkala1 slekkala1 will be requested when the pull request is marked ready for review slekkala1 is a code owner

@franciscojavierarceo franciscojavierarceo Awaiting requested review from franciscojavierarceo franciscojavierarceo will be requested when the pull request is marked ready for review franciscojavierarceo is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Meta Open Source bot.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ehhuang @iamemilio