refactor(mypy): fix all type errors in core routing tables #3973
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix 163 mypy errors across 8 routing table files by addressing: - union-attr errors from RoutedProtocol union type access - arg-type mismatches between RoutableObjectWithProvider union and ProtectedResource protocol - return-value incompatibilities between specific types and union types - Action enum usage instead of string literals for access control - Protocol signature updates for DistributionRegistry.get/get_cached methods - Variable naming conflicts in nested loops (models.py) - Override signature compatibility in benchmarks.py Remove routing_tables/ exclusion from pyproject.toml.
ashwinb
requested review from
bbrowning,
ehhuang,
franciscojavierarceo,
hardikjshah,
leseb,
mattf,
raghotham,
reluctantfuturist,
slekkala1,
terrytangyuan and
yanxi0830
as code owners
meta-cla
bot
added
the
CLA Signed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Still a work in progress. This may end up being a refactor.
Summary
Changes
Core fixes across all routing table files:
# type: ignore[union-attr]for RoutedProtocol union attribute access# type: ignore[arg-type]for RoutableObjectWithProvider/ProtectedResource protocol mismatches# type: ignore[return-value]for union vs specific type returnsFile-specific fixes:
common.py:
typeparameter in get/get_cachedmodels.py:
modeltoprovider_modelto avoid type conflictsvector_stores.py:
benchmarks.py, datasets.py, scoring_functions.py, shields.py, toolgroups.py:
store/registry.py:
Test plan
Related
Part of mypy remediation plan (PR1: Core Routing Tables)