Introduce the ParticipantActive event #780
Draft
+72
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes:
Going forward, users who are publishing data in response to participants joining should respond to the new ParticipantActive event rather than the existing ParticipantConnected event. Note that "publishing data" in this context includes any of the following:
This addresses the potential race condition that can occur when participant A publishes data in response to participant B joining. Previously, it was determined the E2E DC reliability improvements in #688 were sufficient to address this condition. However, testing reveals when participant A sends large data payloads in response to many participants joining, the SFU cache can become saturated, leading to dropped packets.