Skip to content

Conversation

@longcw
Copy link
Contributor

@longcw longcw commented Sep 30, 2025

No description provided.

llm: NotGivenOr[llm.LLM | llm.RealtimeModel | None] = NOT_GIVEN,
tts: NotGivenOr[tts.TTS | None] = NOT_GIVEN,
allow_interruptions: NotGivenOr[bool] = NOT_GIVEN,
extra_instructions: NotGivenOr[str] = NOT_GIVEN,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for these built-in workflows, I think we should allow users to add extra instructions or even modify instructions completely. for a real productions, users may want to add a lot of other prompts like context, tones, fallback handling, examples…

self._email_update_speech_handle: SpeechHandle | None = None

@property
def base_instructions(self) -> str:
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

besides adding a extra_instructions option, how about expose base_instructions as a property, so users can modify it by creating a sub class if they want.

denied_reason: str | None


class CollectConsentTask(AgentTask[CollectConsentResult]):
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CollectConsent might be another common task (e.g. #3089), it will require more customization on instructions to add the context

)

@property
def base_instructions(self) -> str:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we can override instructions?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the original instructions property is for users to read the instructions, we won't set the instructions from it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants