Add copy buttons to embed code snippets #43
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
1egoman
commented
Sep 26, 2025
Comment on lines
+126
to
+144
| {iframeEmbedCode.split(iframeEmbedUrl).map((stringPart, index) => { | ||
| if (index === 0) { | ||
| return <span key={index}>{stringPart}</span>; | ||
| } | ||
|
|
||
| return ( | ||
| <span key={index}> | ||
| <a | ||
| href={iframeEmbedUrl} | ||
| target="_blank" | ||
| rel="noopener noreferrer" | ||
| className="text-primary underline" | ||
| > | ||
| {iframeEmbedUrl} | ||
| </a> | ||
| {stringPart} | ||
| </span> | ||
| ); | ||
| })} |
There was a problem hiding this comment.
What I did here was a little weird... by splitting the embed code string on the iframeEmbedUrl, it gave me all the parts around any embed url instances. Then, between each occurrence, I inserted the a tag to maintain the previous behavior where the url was linked.
I tried a few other things but couldn't find come up with something that was cleaner - if you've got a better suggestion, let me know!
lukasIO
approved these changes
Sep 29, 2025
thomasyuill-livekit
approved these changes
Sep 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the ability to copy embed code with a button from the welcome page.
iFrame embed:
Popup embed:
