Skip to content

fix: not checking ignorelist for application name #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: not checking ignorelist for application name #1

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions brew_cask_replace.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ def generate_cask_token(application_path, application_name):
def replace_application_in(
applications_dir, always_yes=False, skip_app_from_appstore=True
):
os.system('brew cask list > ignorecask.txt')
os.system('brew list --cask > ignorecask.txt')
ignores = parse_ignores(os.path.join(os.path.dirname(__file__), 'ignore.txt'))
ignorescask = parse_ignorescask(os.path.join(os.path.dirname(__file__), 'ignorecask.txt'))
not_founded = []
Expand Down Expand Up @@ -126,7 +126,7 @@ def replace_application_in(
cask = application_info[application_info.find("'")+1:].split()[0]
caskapp = cask.strip('\'"')

if caskapp in ignorescask:
if caskapp in ignorescask or application_name in ignorescask:
continue

print('{0} -> {1}'.format(application, application_info))
Expand Down