-
-
Notifications
You must be signed in to change notification settings - Fork 29
Also validate args for clojure tools usage #284
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
lread
wants to merge
11
commits into
liquidz:main
Choose a base branch
from
lread:lread/cli-opts-validation
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Switched from clojure.tools/cli to org.babashka/cli for command line parsing. Usage help is now shown on request, via `--help` for -M usage or `:help true` for -T and -X tool usage, and on usage error. Usage help shows appropriate option syntax for -M vs -T usage. Help is also shown on usage error. Now emit a warning on deprecated option usage (currently only --no-diff is deprecated). I did not realize all multi value args support `:` separator syntax. Updated README accordingly. Cli tests updated accordingly and I brought in nubank's matcher combinators to make comparisons easy to write and error diffs easy to read. After I tackle liquidz#274, I'll incorporate these checks for lein plugin usage. Closes liquidz#280
test now has deps, bring in test alias
brought it over from bb cli, but don't need it.
Happily get rid of our antq.cli.table ns
Hi @liquidz when you find some time, looking forward to learning what you think. With babashka cli, it is relatively easy to add usage help, so did that. -M usage:
-T usage:
|
Hi @liquidz, I expect you are busy with life and other things. |
Hi @liquidz! I am still happy to bring this one to completion, if you find some time/interest. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switched from clojure.tools/cli to org.babashka/cli for command line
parsing.
Usage help is now shown on request, via
--help
for -M usageor
:help true
for -T and -X tool usage, and on usage error.Usage help shows appropriate option syntax for -M vs -T usage.
Help is also shown on usage error.
Now emit a warning on deprecated option usage (currently only --no-diff
is deprecated).
I did not realize all multi value args support
:
separator syntax.Updated README accordingly.
Cli tests updated accordingly and I brought in nubank's matcher
combinators to make comparisons easy to write and error diffs easy to read.
After I tackle #274, I'll incorporate these checks for lein plugin usage.
Closes #280