Skip to content

Conversation

@DenTechs
Copy link

linuxserver.io


  • I have read the contributing guideline and understand that I have made the correct modifications

Description:

Changed the default resolution behavior to use environment variable width and height if set instead of the currently hard coded 1024x768, modeline is generated using CVT.

Benefits of this PR and context:

When a manual resolution is set, instead of defaulting to 1024x768 and then changing on first connect, the manual resolution is used immediately. Additionally this change prevents a bug in my firefox ffmpeg capture fork as it can't handle the resolution changing dynamically.

How Has This Been Tested?

Built and tested with my fork of firefox and confirmed that the resolution was set to the one provided by the environment file instead of the hard coded 1024x768

This change should not have any affects on other areas of the code.

Source / References:

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for opening this pull request! Be sure to follow the pull request template!

@LinuxServer-CI
Copy link
Collaborator

I am a bot, here are the test results for this PR:
https://ci-tests.linuxserver.io/lspipepr/selkies-base/ubuntunoble-3620affb-pkg-3620affb-dev-61dcef89f07c1b0728f96d0fccdce980ccda7090-pr-113/index.html
https://ci-tests.linuxserver.io/lspipepr/selkies-base/ubuntunoble-3620affb-pkg-3620affb-dev-61dcef89f07c1b0728f96d0fccdce980ccda7090-pr-113/shellcheck-result.xml

Tag Passed
amd64-ubuntunoble-3620affb-pkg-3620affb-dev-61dcef89f07c1b0728f96d0fccdce980ccda7090-pr-113
arm64v8-ubuntunoble-3620affb-pkg-3620affb-dev-61dcef89f07c1b0728f96d0fccdce980ccda7090-pr-113

@LinuxServer-CI
Copy link
Collaborator

I am a bot, here are the test results for this PR:
https://ci-tests.linuxserver.io/lspipepr/selkies-base/ubuntunoble-a671365e-pkg-a671365e-dev-e29a081e208330264405e8e0958e5f2b9bc5f9d0-pr-113/index.html
https://ci-tests.linuxserver.io/lspipepr/selkies-base/ubuntunoble-a671365e-pkg-a671365e-dev-e29a081e208330264405e8e0958e5f2b9bc5f9d0-pr-113/shellcheck-result.xml

Tag Passed
amd64-ubuntunoble-a671365e-pkg-a671365e-dev-e29a081e208330264405e8e0958e5f2b9bc5f9d0-pr-113
arm64v8-ubuntunoble-a671365e-pkg-a671365e-dev-e29a081e208330264405e8e0958e5f2b9bc5f9d0-pr-113

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Development

Successfully merging this pull request may close these issues.

2 participants