Changed default resolution behavior to use environment variable width and height if set instead of hard coded 1024x768 #113
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Changed the default resolution behavior to use environment variable width and height if set instead of the currently hard coded 1024x768, modeline is generated using CVT.
Benefits of this PR and context:
When a manual resolution is set, instead of defaulting to 1024x768 and then changing on first connect, the manual resolution is used immediately. Additionally this change prevents a bug in my firefox ffmpeg capture fork as it can't handle the resolution changing dynamically.
How Has This Been Tested?
Built and tested with my fork of firefox and confirmed that the resolution was set to the one provided by the environment file instead of the hard coded 1024x768
This change should not have any affects on other areas of the code.
Source / References: