added nav links #22
Open
added nav links #22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
index.html
Outdated
| @@ -48,6 +48,12 @@ | |||
| </div> | |||
| <button type="submit" class="btn btn-success">Sign in</button> | |||
| </form> --> | |||
| <div class="topnav"> | |||
| <a href="#">Contact</a> | |||
There was a problem hiding this comment.
These should now point to a valid anchor tag on the page.
nileshgulia1
force-pushed
the
nav-buttons
branch
from
edf4b07 to
0e62f7d
Compare
nileshgulia1
commented
Jan 21, 2018
| @@ -48,6 +48,12 @@ | |||
| </div> | |||
| <button type="submit" class="btn btn-success">Sign in</button> | |||
| </form> --> | |||
| <div class="topnav"> | |||
| <a href="#contact">Contact</a> | |||
|
@CuriousLearner I'm unsure why |
|
I am clueless right now about that. But as far as I remember it wasn't the requirement anytime. Maybe @nileshgulia1 added it on his own. |
|
Ah, I just followed traditional landing page concepts for navbars :), my bad. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #21
@CuriousLearner Please review