Skip to content

Add check for non-inclusive language #142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 3, 2023
Merged

Add check for non-inclusive language #142

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
eb842ae
Add check for non-inclusive language
nhosoi Dec 15, 2022
f9f9a13
Cleanup non-inclusive words
nhosoi Dec 15, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions .github/workflows/woke.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
# yamllint disable rule:line-length
name: Check for non-inclusive language
on: # yamllint disable-line rule:truthy
- pull_request
jobs:
woke:
name: woke
runs-on: ubuntu-latest
steps:
- name: Checkout
uses: actions/checkout@v3

- name: woke
uses: get-woke/woke-action@v0
with:
woke-args: "-c https://raw.githubusercontent.com/linux-system-roles/tox-lsr/main/src/tox_lsr/config_files/woke.yml"
# Cause the check to fail on any broke rules
fail-on-error: true
6 changes: 3 additions & 3 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ correct ones).

### Other Changes

- changelog_to_tag action - support other than "master" for the main branch name (#129)
- changelog_to_tag action - github action ansible test improvements

[1.1.6] - 2022-07-19
--------------------
Expand Down Expand Up @@ -183,14 +183,14 @@ must be a `string` value like `"2.9"`, not a `float` value like `2.9`.

### Bug fixes

- Fix some ansible-test sanity errors; suppressing the rest
- Fix some ansible-test errors; suppressing the rest
- Fix ansible-test errors
- Add a note to each module Doc to indicate it is private

### Other Changes

- Remove python-26 environment from tox testing
- update to tox-lsr 2.4.0 - add support for ansible-test sanity with docker
- update to tox-lsr 2.4.0 - add support for ansible-test with docker
- CI: Add support for RHEL-9

[1.0.2] - 2021-02-12
Expand Down
2 changes: 1 addition & 1 deletion tests/tasks/setup_ipa.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,9 +10,9 @@
when: __is_beaker_env

- name: Clone ansible-freeipa repo
# noqa git-latest
git:
repo: https://github.com/freeipa/ansible-freeipa
version: master
Copy link

@rafasgj rafasgj Dec 16, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here's what I meant about the use of 'master'. We can safely pin version 'v1.9.0' and update it if we need in the future.

On the maintainance cost of updating it, I believe it will be updated soon, but not often.

Copy link
Collaborator

@richm richm Dec 16, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why can't we just omit version altogether, then git will use whatever is the default branch?

Copy link

@rafasgj rafasgj Dec 16, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we can, it would be better. I though it was required.

Copy link
Contributor Author

@nhosoi nhosoi Dec 16, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is not required by the git module, but it is by ansible-lint. So, we are adding this line to skip the check by ansible-lint.
https://github.com/linux-system-roles/certificate/pull/142/files#diff-d1ca26ec3f441ccd0c4bb18b601d19668a8ffacfab0c71694fea7b46adc9823cR13

dest: /tmp/freeipa-repo
delegate_to: 127.0.0.1
become: false
Expand Down