perftest: enable CQ events support for WRITE_IMM operations #348
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove the restriction that prevented WRITE_IMM operations from using completion queue events. As WRITE_IMM posts to the reciever CQ, there's no reason not to support the event parameter (-e) as in WRITE. Changes include: - Remove WRITE_IMM exclusion from events parameter parsing - Add CQ notification setup for write_bw and write_lat tools - Implement event notification in run_iter_lat_write_imm() - Update polling logic to respect use_event flag Reviewed-by: Michael Margolin <[email protected]> Reviewed-by: Yonatan Nachum <[email protected]> Signed-off-by: Ramon Fried <[email protected]>
mellowcandle
force-pushed
the
imm_cq_events
branch
from
9ffe64b to
354163a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the restriction that prevented WRITE_IMM operations from using
completion queue events. As WRITE_IMM posts to the reciever CQ, there's
no reason not to support the event parameter (-e) as in WRITE.
Changes include: