Skip to content

Conversation

Yue-ByteDance
Copy link

@Yue-ByteDance Yue-ByteDance commented Sep 2, 2025

Currently, perftest supports RDMA Write / Write-with-Immediate / Send /
Read and Atomic operations, but lacks Send-with-Immediate support. This
commit adds Send-with-Immediate functionality, allowing users to test it
via ib_send_bw with --send_with_imm flag.

Additionally, to verify the completion logic for operations with
immediate data is correct, completion events are now validated to ensure
the IBV_WC_WITH_IMM flag is set.

@mrgolin
Copy link
Contributor

mrgolin commented Sep 2, 2025

Generally looks good to me but I think we should add a check in run_iter_bw* and run_iter_lat that completion really has imm data. Something like:

if (user_param->use_send_with_imm && !(wc[i].wc_flags & IBV_WC_WITH_IMM)) {
        // error
        ...

Also can you please describe your changes in the commit message?

@Yue-ByteDance
Copy link
Author

Generally looks good to me but I think we should add a check in run_iter_bw* and run_iter_lat that completion really has imm data. Something like:

if (user_param->use_send_with_imm && !(wc[i].wc_flags & IBV_WC_WITH_IMM)) {
        // error
        ...

Also can you please describe your changes in the commit message?

No problem, I will push a new version later

Currently, perftest supports RDMA Write / Write-with-Immediate / Send /
Read and Atomic operations, but lacks Send-with-Immediate support. This
commit adds Send-with-Immediate functionality, allowing users to test it
via ib_send_bw with --send_with_imm flag.

Additionally, to verify the completion logic for operations with
immediate data is correct, completion events are now validated to ensure
the IBV_WC_WITH_IMM flag is set.

Signed-off-by: Zelong Yue <[email protected]>
@Yue-ByteDance Yue-ByteDance changed the title Perftest: Add support for send with imm verb Perftest: Add support for Send with Immediate verb Sep 30, 2025
@Yue-ByteDance
Copy link
Author

@mrgolin I've updated the code and the commit message with your suggestion, could you please take a look at the new version? Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants