-
Notifications
You must be signed in to change notification settings - Fork 33
Convert test_loaders_pydantic.py to pytest format #446
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Convert test_loaders_pydantic.py to pytest format #446
Conversation
vladistan
commented
Aug 2, 2025
- Extract loader_test helper function from base class
- Convert 4 test methods to standalone functions
- Test both YAML and JSON loaders with different models
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #446 +/- ##
=======================================
Coverage 77.41% 77.41%
=======================================
Files 52 52
Lines 4476 4476
Branches 1303 1303
=======================================
Hits 3465 3465
Misses 783 783
Partials 228 228 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
use pytest.mark.parametrize
instead of the individual test functions
4150589
to
87c9f70
Compare
87c9f70
to
c1c94ae
Compare
bb35ddc
to
96d34dc
Compare
weird... works on my machine :-( |
e96c670
to
4089c9f
Compare
The issue here is that there is a test somewhere that's creating the files that these tests are using for comparison (the files already exist if you've run the tests locally, which is why it's so hard to debug locally). Files need to be added to the repo for these comparisons to execute correctly. The potentially bigger problem is that some directories are being git-ignored and this problem may affect numerous files in the repo. |
- Extract loader_test helper function from base class - Convert 4 test methods to standalone functions - Test both YAML and JSON loaders with different models
929b645
to
af32ced
Compare