Skip to content

Conversation

@JvD-Ericsson
Copy link
Contributor

Summary

  1. Why: Jetty 12 requires a minimum of Java 17, so Java 11 must be dropped to facilitate this upgrade Upgrade jetty to 12.0.12 #2307. The current version of Jetty in cruise-control is 9.4.56.v20240826. This version contains two CVEs

So, Jetty 12 is needed to patch CVE-2024-6763.

  1. What: Remove support support for Java 11. Raise minimum JDK to 17 in builds, docs, and workflows

Categorization

  • refactor

1. Why:
Jetty 12 requires a minimum of Java 17, so Java 11 must be dropped to facilitate this upgrade.
The current version of Jetty in cruise-control is 9.4.56.v20240826. This version contains two CVEs
CVE-2024-13009 - patched in 9.4.57.v20241219
CVE-2024-6763 - patched in 12.0.12
So, Jetty 12 is need to patch CVE-2024-6763.

2. What:
Remove support support for Java 11
Raise minimum JDK to 17 in builds, docs, and workflows

- [x] refactor

Signed-off-by: JvD_Ericsson <[email protected]>
@JvD-Ericsson JvD-Ericsson mentioned this pull request Sep 19, 2025
1 task
@pnagy-cldr pnagy-cldr mentioned this pull request Sep 25, 2025
6 tasks
Copy link

@danielgospodinow danielgospodinow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@danielgospodinow
Copy link

@kyguy, can you review this PR once you have some bandwidth? Because it's kind of blocking #2244, which is a fantastic initiative IMO.

Copy link
Contributor

@kyguy kyguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In hindsight, I wish we had added a deprecation notice for Java 11 when we added support for Java 17 some months back. That being said, dropping Java 11 now is a reasonable step especially given that it's required to address certain CVEs (some listed in the PR description) and to support newer Kafka versions (Kafka >= 4.0).

As far as backward compatibility is concerned, Java 17 has been supported in Kafka since version 3.2.0 [1]. Although Cruise Control’s main branch currently only supports Kafka >= 3.7.0, it’s still important to maintain compatibility with as many Kafka versions as possible to serve the broadest range of users in the community. So this change is in line with that goal as well.

I have tested this change and have been running builds with Java 17 for some time now, this looks like a reasonable update to me. We just need a maintainer to sign off and merge.

[1] https://kafka.apache.org/32/documentation.html#java

Copy link
Contributor

@CCisGG CCisGG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the change. LGTM.

@CCisGG CCisGG merged commit 86e3127 into linkedin:main Sep 29, 2025
6 checks passed
danielgospodinow pushed a commit to qbaware/cruise-control that referenced this pull request Oct 5, 2025
1. Why:
Jetty 12 requires a minimum of Java 17, so Java 11 must be dropped to facilitate this upgrade.
The current version of Jetty in cruise-control is 9.4.56.v20240826. This version contains two CVEs
CVE-2024-13009 - patched in 9.4.57.v20241219
CVE-2024-6763 - patched in 12.0.12
So, Jetty 12 is need to patch CVE-2024-6763.

2. What:
Remove support support for Java 11
Raise minimum JDK to 17 in builds, docs, and workflows

- [x] refactor

Signed-off-by: JvD_Ericsson <[email protected]>
danielgospodinow pushed a commit to qbaware/cruise-control that referenced this pull request Oct 5, 2025
1. Why:
Jetty 12 requires a minimum of Java 17, so Java 11 must be dropped to facilitate this upgrade.
The current version of Jetty in cruise-control is 9.4.56.v20240826. This version contains two CVEs
CVE-2024-13009 - patched in 9.4.57.v20241219
CVE-2024-6763 - patched in 12.0.12
So, Jetty 12 is need to patch CVE-2024-6763.

2. What:
Remove support support for Java 11
Raise minimum JDK to 17 in builds, docs, and workflows

- [x] refactor

Signed-off-by: JvD_Ericsson <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants