Skip to content

Log exceptions when unable to list topics or describe cluster config #2131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Log exceptions when unable to list topics or describe cluster config #2131

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
caa5bb3
log exception when unable to list topic names
marcelloromani Mar 3, 2024
c073ddf
log exception when unable to desribe kafka cluster configs
marcelloromani Mar 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .../src/main/java/com/linkedin/kafka/cruisecontrol/config/KafkaAdminTopicConfigProvider.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,7 +140,7 @@ public Map<String, Properties> allTopicConfigs() {
try {
topicNames = _adminClient.listTopics().names().get();
} catch (InterruptedException | ExecutionException e) {
LOG.warn("Unable to obtain list of all topic names from the Kafka Cluster");
LOG.warn("Unable to obtain list of all topic names from the Kafka Cluster: " + e);
}

if (topicNames == null) {
Expand Down Expand Up @@ -171,7 +171,7 @@ public void configure(Map<String, ?> configs) {
try {
clusterConfigs = describeClusterConfigs(_adminClient, DESCRIBE_CLUSTER_CONFIGS_TIMEOUT);
} catch (InterruptedException | ExecutionException e) {
throw new RuntimeException("Failed to describe Kafka cluster configs.");
throw new RuntimeException("Failed to describe Kafka cluster configs: " + e);
}

if (clusterConfigs != null) {
Expand Down