Skip to content

Add verbose parameter to remove-disks endpoint valid parameter list #2106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Add verbose parameter to remove-disks endpoint valid parameter list #2106

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
219c572
Added verbose and skip_hard_goal_check parameter to remove-disks end…
ShubhamRwt Jan 11, 2024
8371064
Revert unwanted change
ShubhamRwt Jan 11, 2024
de4b4a4
Removed skip_hard_goal_check parameter
ShubhamRwt May 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions .../main/java/com/linkedin/kafka/cruisecontrol/servlet/parameters/RemoveDisksParameters.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@
import static com.linkedin.kafka.cruisecontrol.servlet.parameters.ParameterUtils.REASON_PARAM;
import static com.linkedin.kafka.cruisecontrol.servlet.parameters.ParameterUtils.STOP_ONGOING_EXECUTION_PARAM;
import static com.linkedin.kafka.cruisecontrol.servlet.parameters.ParameterUtils.JSON_PARAM;
import static com.linkedin.kafka.cruisecontrol.servlet.parameters.ParameterUtils.VERBOSE_PARAM;

public class RemoveDisksParameters extends GoalBasedOptimizationParameters {
protected static final SortedSet<String> CASE_INSENSITIVE_PARAMETER_NAMES;
Expand All @@ -26,12 +27,14 @@ public class RemoveDisksParameters extends GoalBasedOptimizationParameters {
validParameterNames.add(BROKER_ID_AND_LOGDIRS_PARAM);
validParameterNames.add(DRY_RUN_PARAM);
validParameterNames.add(REASON_PARAM);
validParameterNames.add(VERBOSE_PARAM);
validParameterNames.add(STOP_ONGOING_EXECUTION_PARAM);
validParameterNames.add(JSON_PARAM);
CASE_INSENSITIVE_PARAMETER_NAMES = Collections.unmodifiableSortedSet(validParameterNames);
}
private boolean _dryRun;
private String _reason;
private boolean _verbose;
private boolean _stopOngoingExecution;
private Map<Integer, Set<String>> _logdirByBrokerId;

Expand All @@ -44,6 +47,7 @@ protected void initParameters() throws UnsupportedEncodingException {
super.initParameters();
_logdirByBrokerId = ParameterUtils.brokerIdAndLogdirs(_requestContext);
_dryRun = ParameterUtils.getDryRun(_requestContext);
_verbose = ParameterUtils.isVerbose(_requestContext);
boolean requestReasonRequired = _config.getBoolean(ExecutorConfig.REQUEST_REASON_REQUIRED_CONFIG);
_reason = ParameterUtils.reason(_requestContext, requestReasonRequired && !_dryRun);
_stopOngoingExecution = ParameterUtils.stopOngoingExecution(_requestContext);
Expand All @@ -68,6 +72,9 @@ public SortedSet<String> caseInsensitiveParameterNames() {
public String reason() {
return _reason;
}
public boolean verbose() {
return super.isVerbose();
}
public boolean dryRun() {
return _dryRun;
}
Expand Down
6 changes: 6 additions & 0 deletions cruise-control/src/main/resources/yaml/endpoints/removeDisks.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,12 @@ RemoveDisksEndpoint:
schema:
type: boolean
default: false
- name: verbose
in: query
description: Return detailed state information.
schema:
type: boolean
default: false
- name: reason
in: query
description: Reason for request.
Expand Down