Add streamTimeout option to WebSocketService/WebSocketClient; send close frame on inbound failure; clean up related resources

[sjy982]

Motivation

• Instead of asking each handler to wrap the inbound stream with StreamMessage.timeout(..., UNTIL_NEXT), expose it as an option on WebSocketServiceBuilder / WebSocketClientBuilder so both server and client can enable it consistently and easily.
• When the inbound completes abnormally (cancel/abort/timeout, etc.), further outbound sends are meaningless. We should immediately tidy up outbound and the stream/channel. If the connection is still valid and the termination is initiated locally, prefer sending a WebSocket close frame (with an appropriate status + reason) over a transport reset, for better reason propagation, interoperability, and observability.

Modifications

• Add WebSocketServiceBuilder#streamTimeout(Duration).

  • When set, wrap inbound in TimeoutStreamMessage with StreamTimeoutMode.UNTIL_NEXT inside DefaultWebSocketService#serve(...).

• Update DefaultWebSocketService#serve(...):

  • If inbound completes with an error, call outbound.abort(mappedCause) so recoverAndResume sends a CloseWebSocketFrame.
  • Map CancelledSubscriptionException / AbortedStreamException to InboundCompleteException to avoid being skipped by the recovery logic.

• Add WebSocketClientBuilder#streamTimeout(Duration).

  • When set, wrap inbound in TimeoutStreamMessage with StreamTimeoutMode.UNTIL_NEXT inside DefaultWebSocketClient#connect(...).

• Update WebSocketSession#setOutbound(...):

  • Attach recoverAndResume(...) to outbound so that on send failure it emits a CloseWebSocketFrame and records the exception in RequestLog (endRequest(cause) / endResponse(cause)). For ClosedStreamException, do not send a close frame—just abort.
  • When inbound completes exceptionally, abort(...) outbound with the mapped cause so the recovery stream kicks in.

• Add InboundCompleteException extends CancellationException:

  • Signals that inbound completed due to cancellation/abort.

• Add a client-side newCloseWebSocketFrame(Throwable) in WebSocketUtil.

Result

• WebSocketService / WebSocketClient can apply StreamMessage.timeout(..., UNTIL_NEXT) to inbound via the simple streamTimeout(Duration) option.
• When inbound completes with an error:
  • If the channel is still usable, abort outbound with the mapped cause so a close frame is sent (skip sending for ClosedStreamException).
  • Record request/response causes in RequestLog.
  • On HTTP/1.x, close the channel; on HTTP/2, clean up the stream.

[github-actions]

🔍 Build Scan® (commit: 1de6137)

Job name	Status	Build Scan®
build-ubicloud-standard-16-jdk-8	✅	https://ge.armeria.dev/s/5hqj5ziorx3d4
build-ubicloud-standard-16-jdk-21-snapshot-blockhound	❌ (failure)	https://ge.armeria.dev/s/v2kllirmzq7r2
build-ubicloud-standard-16-jdk-17-min-java-17-coverage	✅	https://ge.armeria.dev/s/i2gnysixho2d4
build-ubicloud-standard-16-jdk-17-min-java-11	✅	https://ge.armeria.dev/s/v74yas7r5wkl2
build-ubicloud-standard-16-jdk-17-leak	❌ (failure)	https://ge.armeria.dev/s/balvzh2lprwp6
build-ubicloud-standard-16-jdk-11	✅	https://ge.armeria.dev/s/bljoeau3xld46
build-macos-latest-jdk-21	❌ (failure)	https://ge.armeria.dev/s/w5ayc2tt4bite

[jrhee17]

Looks good overall, left some comments

[codecov]

Codecov Report

❌ Patch coverage is 80.45977% with 17 lines in your changes missing coverage. Please review.
✅ Project coverage is 74.14%. Comparing base (8150425) to head (1de6137).
⚠️ Report is 183 commits behind head on main.

Files with missing lines	Patch %	Lines
...rp/armeria/common/stream/TimeoutStreamMessage.java	73.68%	5 Missing ⚠️
...orp/armeria/client/websocket/WebSocketSession.java	75.00%	2 Missing and 2 partials ⚠️
...corp/armeria/common/logging/DefaultRequestLog.java	82.35%	1 Missing and 2 partials ⚠️
...ecorp/armeria/common/InboundCompleteException.java	50.00%	2 Missing ⚠️
...meria/client/websocket/WebSocketClientBuilder.java	80.00%	0 Missing and 1 partial ⚠️
.../linecorp/armeria/common/stream/StreamMessage.java	0.00%	0 Missing and 1 partial ⚠️
...eria/server/websocket/WebSocketServiceBuilder.java	83.33%	0 Missing and 1 partial ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##               main    #6357      +/-   ##
============================================
- Coverage     74.46%   74.14%   -0.33%     
- Complexity    22234    23022     +788     
============================================
  Files          1963     2062      +99     
  Lines         82437    86177    +3740     
  Branches      10764    11317     +553     
============================================
+ Hits          61385    63892    +2507     
- Misses        15918    16872     +954     
- Partials       5134     5413     +279     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.