Skip to content

Conversation

@delucchi-cmu
Copy link
Contributor

Change Description

Closes #542
Closes #538

The initially hydrated __init__.py file was not formatted to ruff standards, and so the initial pre-commit failed when choosing the ruff linting option (the default option).

This PR makes an additional change to REALLY run the pre-commits in the unit tests. This catches all the checks that SHOULD be run, given the copier config that the project is hydrated with. The tests take quite a bit longer, but I think it's well worth it to catch such issues in the future.

Checklist

  • This PR is meant for the lincc-frameworks/python-project-template repo and not a downstream one instead.
  • This change is linked to an open issue
  • This change includes integration testing, or is small enough to be covered by existing tests

Copy link
Contributor

@hombit hombit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works, thanks! Please do not change user's global git settings, even it tests, I believe this type of global changes should happen in CI, not in the test code.

@delucchi-cmu delucchi-cmu requested a review from hombit October 9, 2025 14:09
Copy link
Contributor

@hombit hombit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Copy link
Collaborator

@drewoldag drewoldag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine to me, I believe that it would address the issues that I ran into a few days ago with failing unit tests looking for __version__. Thank you!

@delucchi-cmu delucchi-cmu merged commit 1f11018 into main Oct 9, 2025
5 checks passed
@delucchi-cmu delucchi-cmu deleted the issue/542/ruff branch October 9, 2025 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

.initialize_new_project.sh fails on ruff and pytest-check pre-commit checks Errors when running .initialize_new_project.sh

3 participants