Skip to content

Conversation

@dab246
Copy link
Member

dab246 commented Sep 25, 2025

  • Build CI iOS Failed
Screenshot 2025-09-25 at 10 45 02 AM

Comment on lines +7 to +9
<uses-permission
android:name="android.permission.REQUEST_INSTALL_PACKAGES"
tools:node="remove" />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://pub.dev/packages/better_open_file
better_open_file was not maintained, so I have to change the dependency to open_file, but I have to remove the permission
crazecoder/open_file#204 (comment)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Verify again open_file

Comment on lines +1 to +5
#
# Generated file, do not edit.
#

command script import --relative-to-command-file flutter_lldb_helper.py
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is this?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment on lines +1 to +17
#
# Generated file, do not edit.
#

import lldb

def handle_new_rx_page(frame: lldb.SBFrame, bp_loc, extra_args, intern_dict):
"""Intercept NOTIFY_DEBUGGER_ABOUT_RX_PAGES and touch the pages."""
base = frame.register["x0"].GetValueAsAddress()
page_len = frame.register["x1"].GetValueAsUnsigned()

# Note: NOTIFY_DEBUGGER_ABOUT_RX_PAGES will check contents of the
# first page to see if handled it correctly. This makes diagnosing
# misconfiguration (e.g. missing breakpoint) easier.
data = bytearray(page_len)
data[0:8] = b'IHELPED!'

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is this?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment on lines -173 to +175
better_open_file: 3.6.4
open_file: 3.5.10
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why use open_file? Check if it works properly.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

better_open_file was not maintained

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sure open_file works fine on the app, attach demo video

Comment on lines -292 to +298
patrol: 3.14.0
patrol: 3.19.0

patrol_log: 0.3.0
patrol_log: 0.5.0

patrol_finders: 2.7.2
patrol_finders: 2.9.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also check again E2E

Comment on lines -313 to -321
# TODO: The package publisher fixed the issue with android API 35.
# However, they bundled it with the Flutter 3.27.4.
# When this app upgrade to Flutter 3.27.4, we will update this package
# and remove this override.
flutter_downloader:
git:
url: https://github.com/linagora/flutter_downloader.git
ref: fixbug/android-api-35

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also test download feature

Comment on lines +1036 to +1038
type: Platform.isAndroid ? downloadedResponse.mediaType!.mimeType : null,
// "xdg" is default value
linuxDesktopName: Platform.isIOS
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is linux here?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

linuxDesktopName property is the old uti property renamed.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why xdg is default? What is the document describe this? Also verify download feature on all platform.

@dab246
Copy link
Member

dab246 commented Sep 29, 2025

  • How to verify app is supported on Android 16kb page size?

@tddang-linagora
Copy link
Collaborator Author

How to verify app is supported on Android 16kb page size?

Push a version to Play Console test.

@dab246
Copy link
Member

dab246 commented Sep 29, 2025

How to verify app is supported on Android 16kb page size?

Push a version to Play Console test.

Is there no other way?

@tddang-linagora
Copy link
Collaborator Author

How to verify app is supported on Android 16kb page size?

Push a version to Play Console test.

Is there no other way?

That is the surest way. The app runs fine on 16kb device.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants