-
Notifications
You must be signed in to change notification settings - Fork 97
TF-4058 Support Flutter 3.32.8 and Android 16kb page size #4059
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
<uses-permission | ||
android:name="android.permission.REQUEST_INSTALL_PACKAGES" | ||
tools:node="remove" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we need?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://pub.dev/packages/better_open_file
better_open_file was not maintained, so I have to change the dependency to open_file, but I have to remove the permission
crazecoder/open_file#204 (comment)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Verify again open_file
# | ||
# Generated file, do not edit. | ||
# | ||
|
||
command script import --relative-to-command-file flutter_lldb_helper.py |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
automatically generated by Flutter
https://docs.flutter.dev/add-to-app/ios/project-setup#set-lldb-init-file
# | ||
# Generated file, do not edit. | ||
# | ||
|
||
import lldb | ||
|
||
def handle_new_rx_page(frame: lldb.SBFrame, bp_loc, extra_args, intern_dict): | ||
"""Intercept NOTIFY_DEBUGGER_ABOUT_RX_PAGES and touch the pages.""" | ||
base = frame.register["x0"].GetValueAsAddress() | ||
page_len = frame.register["x1"].GetValueAsUnsigned() | ||
|
||
# Note: NOTIFY_DEBUGGER_ABOUT_RX_PAGES will check contents of the | ||
# first page to see if handled it correctly. This makes diagnosing | ||
# misconfiguration (e.g. missing breakpoint) easier. | ||
data = bytearray(page_len) | ||
data[0:8] = b'IHELPED!' | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
better_open_file: 3.6.4 | ||
open_file: 3.5.10 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why use open_file
? Check if it works properly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
better_open_file was not maintained
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Make sure open_file works fine on the app, attach demo video
patrol: 3.14.0 | ||
patrol: 3.19.0 | ||
|
||
patrol_log: 0.3.0 | ||
patrol_log: 0.5.0 | ||
|
||
patrol_finders: 2.7.2 | ||
patrol_finders: 2.9.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also check again E2E
# TODO: The package publisher fixed the issue with android API 35. | ||
# However, they bundled it with the Flutter 3.27.4. | ||
# When this app upgrade to Flutter 3.27.4, we will update this package | ||
# and remove this override. | ||
flutter_downloader: | ||
git: | ||
url: https://github.com/linagora/flutter_downloader.git | ||
ref: fixbug/android-api-35 | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also test download feature
type: Platform.isAndroid ? downloadedResponse.mediaType!.mimeType : null, | ||
// "xdg" is default value | ||
linuxDesktopName: Platform.isIOS |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why is linux here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
linuxDesktopName
property is the old uti
property renamed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why xdg
is default? What is the document describe this? Also verify download feature on all platform.
|
Push a version to Play Console test. |
Is there no other way? |
That is the surest way. The app runs fine on 16kb device. |
Issue
Dependencies