Skip to content

Standardize HTML sanitizing when preview email #3223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Oct 24, 2024
Merged

Standardize HTML sanitizing when preview email #3223

merged 9 commits into from
Oct 24, 2024

Conversation

@dab246
Copy link
Member

@dab246 dab246 commented Oct 23, 2024 •
edited
Loading

@dab246 dab246 requested a review from hoangdat October 23, 2024 08:29
@dab246 dab246 force-pushed the hotfix/sanitize_html branch from edddd1a to 94e2c31 Compare October 23, 2024 08:32
@github-actions
Copy link

github-actions bot commented Oct 23, 2024

This PR has been deployed to https://linagora.github.io/tmail-flutter/3223.

@dab246 dab246 force-pushed the hotfix/sanitize_html branch from 94e2c31 to f64cc96 Compare October 23, 2024 08:53
chibenwa
chibenwa reviewed Oct 23, 2024
View reviewed changes
chibenwa
chibenwa reviewed Oct 23, 2024
View reviewed changes
@dab246 dab246 requested a review from chibenwa October 23, 2024 09:29
@hoangdat
Copy link
Member

hoangdat commented Oct 23, 2024 •
edited by dab246
Loading

  • inline image was not display
Screenshot 2024-10-23 at 16 28 40

chibenwa
chibenwa reviewed Oct 23, 2024
View reviewed changes
@hoangdat
Copy link
Member

hoangdat commented Oct 23, 2024 •
edited
Loading

@dab246
Copy link
Member Author

dab246 commented Oct 23, 2024

  • inline image was not display
Screenshot 2024-10-23 at 16 28 40

Fixed

Screen.Recording.2024-10-23.at.19.06.22.mov
  • in Android, this email is not fit as before
    Uploading ⛳ Tous les coups comptent ! 😄.eml.zip…

Before and after applying sanitize html nothing changes. The actual width of the email is larger than the screen width so it will allow horizontal scrolling.

demo.webm

@dab246 dab246 requested review from chibenwa and hoangdat October 23, 2024 12:18
@hoangdat
Copy link
Member

hoangdat commented Oct 23, 2024 •
edited by dab246
Loading

  • should migrate db (...)

@dab246
Copy link
Member Author

dab246 commented Oct 24, 2024

  • should migrate db (...)

Updated

@dab246
Copy link
Member Author

dab246 commented Oct 24, 2024 •
edited
Loading

Fixed

demo.webm

@hoangdat
Copy link
Member

hoangdat commented Oct 24, 2024 •
edited
Loading

  • should have ADR: which attribute, tag, class we allowed. Sequence of this.....

@dab246 dab246 requested a review from guimard October 24, 2024 07:39
@hoangdat hoangdat merged commit 3205e00 into master Oct 24, 2024
22 checks passed
@hoangdat hoangdat deleted the hotfix/sanitize_html branch September 19, 2025 02:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@guimard guimard guimard approved these changes

@hoangdat hoangdat hoangdat approved these changes

@chibenwa chibenwa chibenwa approved these changes

@tddang-linagora tddang-linagora tddang-linagora approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@dab246 @hoangdat @guimard @chibenwa @tddang-linagora