#186 add toggle function to show and hide contact menu #187
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabienmoyon
reviewed
Mar 1, 2022
| contactAsidClass.toggle('hidden'); | ||
| } | ||
|
|
||
| function toggleSideMenuEvent() { |
There was a problem hiding this comment.
I don't understand, why not use the same logic as the Calendar module ? Of course and it will be appreciate to refacto the Contact module and like this not do jquery code
There was a problem hiding this comment.
in calendar is more simple , there are already a service to toggle Menu . It is not the some case in contact SPA
This is the calendar's function
$rootScope.$on('toggleSideMenu', function() {
const sidebarVisibility = calendarSidebarService.getSidebarVisibility();
calendarSidebarService.setSidebarVisibility(!sidebarVisibility);
});
}
There was a problem hiding this comment.
cool so why I not write the same toggle menu service for Contact SPA 👍 to have the same logic in both SPAs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Demo :
closeandhidemenuContacts.mp4